Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DecodeSchema and DecodeSchemaJSON with custom Decoder #8

Open
bminer opened this issue Oct 11, 2021 · 0 comments
Open

Replace DecodeSchema and DecodeSchemaJSON with custom Decoder #8

bminer opened this issue Oct 11, 2021 · 0 comments
Labels
high-priority

Comments

@bminer
Copy link
Owner

bminer commented Oct 11, 2021

Replace DecodeSchema and DecodeSchemaJSON with something like NewSchemaDecoder and NewJSONSchemaDecoder.

I'd like to mirror the JSON decoder API to provide a Buffered() method that returns an io.Reader.

  • func (Decoder) Buffered() bufio.Reader
  • func (Decoder) Decode() (Schema, error)

This makes it clearer that the io.Reader is a buffered reader, and it exposes the buffered but unconsumed contents of the Reader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bminer