Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality (pycheck/flake8/black) (without pyright) #9

Closed
boot-sandre opened this issue Oct 6, 2023 · 3 comments
Closed

Improve code quality (pycheck/flake8/black) (without pyright) #9

boot-sandre opened this issue Oct 6, 2023 · 3 comments
Assignees
@boot-sandre
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Milestone
Skii Platform 0.6.0

Comments

@boot-sandre
Copy link
Owner

Code score: 45/100

  • Formatting: 10/10
  • Codestyle: 35/60
  • Typing: 0/30

Running quality checks

Not famous :P
@boot-sandre boot-sandre added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Oct 6, 2023
@boot-sandre boot-sandre changed the title Improve code quality (pycheck) Improve code quality (pycheck/flake8/black/pyright) Oct 7, 2023
@boot-sandre
Copy link
Owner Author

Improved^^
Code score: 80/100

  • Formatting: 10/10
  • Codestyle: 60/60
  • Typing: 10/30

@boot-sandre boot-sandre added this to the Skii Platform 0.0.6 milestone Oct 7, 2023
@boot-sandre boot-sandre moved this from Todo to Long term progress in @boot-sandre's Skii Platform Oct 7, 2023
@boot-sandre
Copy link
Owner Author

Typing is very low but it's a big work to fix them. Actually the project is fully flake/black. We create an issue related only to pyright check #23

@boot-sandre boot-sandre changed the title Improve code quality (pycheck/flake8/black/pyright) Improve code quality (pycheck/flake8/black) (without pyright) Oct 20, 2023
@boot-sandre
Copy link
Owner Author

As main branch project is black/flake, we can close this issue.

@github-project-automation github-project-automation bot moved this from Long term progress to Done in @boot-sandre's Skii Platform Oct 20, 2023
@boot-sandre boot-sandre self-assigned this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boot-sandre boot-sandre

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
@boot-sandre's Skii Platform
Status: Done
Milestone
Skii Platform 0.6.0
Development

No branches or pull requests
1 participant
@boot-sandre