Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After flip, an image is not "trimmed" to its drawn area #76

Closed
maueroats opened this issue Sep 14, 2023 · 2 comments
Closed

After flip, an image is not "trimmed" to its drawn area #76

maueroats opened this issue Sep 14, 2023 · 2 comments
Assignees
Labels

Comments

@maueroats
Copy link

Both flip-vertical and flip-horizontal screw up the bounding box handling. Apparently after a flip everything inside the bounding box is considered part of the image, not just the drawn part. Unlike DrRacket and non-flipped WeScheme images.

Sample code (first line for DrRacket only):

(require 2htdp/image)
(define good (triangle 100 "solid" "orange"))
(define bad (flip-horizontal (triangle 100 "solid" "blue")))
(beside good bad)

(beside/align "bottom"
              (frame (rotate 60 good))
              (frame (rotate 60 bad)))

Results from DrRacket 8.9 CS, as expected:
image

Results from WeScheme.org today:
image

The whitespace around the blue triangle ("bad") is expanded, presumably including the space outside of the triangle in the figure.

@schanzer
Copy link
Member

Definitely a serious bug, and likely related to #55 .

@schanzer schanzer self-assigned this Mar 17, 2024
schanzer pushed a commit that referenced this issue Mar 17, 2024
…m to make the flipped image a vertex-based image as well (fixes #76)
@schanzer
Copy link
Member

@maueroats confirming this is now fixed on https://300-dot-wescheme-hrd-2.appspot.com/openEditor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants