[#7674] Add support for AWS batch retry limit #7675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When submitting jobs to AWS Batch, Cromwell dynamically creates job definitions based on the job configuration. However, the current implementation does not provide a way for users to configure the Batch retry limit in the job definition. This PR introduces a new batchRetry parameter in the configuration, allowing users to specify a default retry limit for AWS Batch jobs. The parameter is also included in the job runtime settings. By default, batchRetry is set to 0, effectively disabling retries unless explicitly configured by the user.
|
Hi, We maintain an aws specific fork that has these functionalities . Check it out here: https://github.com/henriqueribeiro/cromwell Or my latest dev release forked from that one : https://github.com/geertvandeweyer/cromwell Best, |
|
Oh, I don't know this. Thanks for the info. It looks good. Is there any document for what you have changed for the aws batch? Specifically I am looking for the batch retry parameter. |
|
Oh, I found it. Please ignore the previous comment. Nice work. Thanks! |
|
I am closing this PR because there are already solutions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When submitting jobs to AWS Batch, Cromwell dynamically creates job definitions based on the job configuration. However, the current implementation does not provide a way for users to configure the Batch retry limit in the job definition.
This PR introduces a new batchRetry parameter in the configuration, allowing users to specify a default retry limit for AWS Batch jobs. The parameter is also included in the job runtime settings. By default, batchRetry is set to 0, effectively disabling retries unless explicitly configured by the user.