Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Must patch DemeterBuilder.pm to run on a Mac #60

Open
joefowler opened this issue Nov 5, 2019 · 1 comment
Open

Must patch DemeterBuilder.pm to run on a Mac #60

joefowler opened this issue Nov 5, 2019 · 1 comment

Comments

@joefowler
Copy link

joefowler commented Nov 5, 2019

Hi Bruce. I'm your friendly MacPorts maintainer. As you can see at their issue tracker 55973, I have had to apply a source patch to DemeterBuilder.pm from your release v0.9.26 in order for it to build on a Mac.

In essence, I deleted the do-nothing Mac OSX case from sub ACTION_compile_ifeffit_wrapper. While I was at it, I also deleted sub ACTION_test_for_larchserver, because it was throwing off my syntax highlighter. (I don't understand that.)

I don't understand why this is a new problem, because that file has been mostly unchanged for years, but so it goes. I'll attach the patch that seemed to work for me. I've submitted it as a MacPorts patch for use with 0.9.26, but perhaps you'd consider incorporating it (or something better) in your future releases? I'm sure you can do better, because I know almost zero Perl.

@joefowler
Copy link
Author

Here's the patch for DemeterBuilder.pm:

patch-build-darwin-fix.diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant