Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows bat files should explicitly set paths #9

Open
newville opened this issue Nov 30, 2012 · 0 comments
Open

Windows bat files should explicitly set paths #9

newville opened this issue Nov 30, 2012 · 0 comments

Comments

@newville
Copy link
Contributor

Hi Bruce,

Sorry that I'm not grokking the perl well enough to issue a pull request, but I think you want to change win/inno/modify_path.pl to end up with

@Rem = '---Perl---
@echo off
SET PATH=C:strawberry\perl\bin;C:\strawberry\c\bin;C:\strawberry\perl\site\bin;%PATH%
C:\strawberry\perl\bin\perl.exe -x -S "%0" %1 %2 %3 %4 %5 %6 %7 %8 %9 > "%APPDATA%\demeter\dartemis.log" 2>&1
goto endofperl

etc, with the paths calculated from your
my $app = $ARGV[0] || 'C:\strawberry';
my $target = catfile($app, 'perl', 'site', 'bin');
my $perlexe = catfile($app, 'perl', 'bin', 'perl.exe');

I think if you do this, then you could consider changing the installer to not explicitly put C:\strawberry.... into the system path. For folks who want this in their path, you could include a simple bat file that simply appended the path SET PATH=%PATH%;C:\strawberry\perl....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant