Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with tailwind #127

Open
FranciscoKloganB opened this issue Sep 26, 2022 · 1 comment
Open

Incompatible with tailwind #127

FranciscoKloganB opened this issue Sep 26, 2022 · 1 comment

Comments

@FranciscoKloganB
Copy link

Recently detected that it is not possible to define width and height using tailwind directives because defaultStyles, is applied on rect.

const RectShape: React.FC<Props> = ({ className, style, color }) => {
  const defaultStyle = {
    backgroundColor: color,
    width: '100%',
    height: '100%',
    marginRight: 10
  };

  return (
    <div
      className={joinClassNames('rect-shape', className)}
      style={{ ...defaultStyle, ...style }}
    />
  );
};

Would you mind modifying the API to support these use cases or would you be open to a PR without breaking changes, which allowed both behaviours?

@BrianMitchL
Copy link
Contributor

I'd be happy to look at a PR if you'd like to add the use case without breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants