Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First parameter of assign in SQLUpdate not escaped #58

Open
NoLdman opened this issue Jan 20, 2020 · 0 comments
Open

First parameter of assign in SQLUpdate not escaped #58

NoLdman opened this issue Jan 20, 2020 · 0 comments

Comments

@NoLdman
Copy link

NoLdman commented Jan 20, 2020

In

sortablefile/src/Forms/SortableUploadField.php

Line 199 in 0028923

->assign($sortColumn, $sort++)
the first parameter of assign isn't escaped, which causes SilverStripe-Installations with PostgreSQL databases to cast the column to lower-case (i.e. "sortorder").

Shouldn't it be escaped as follows?

->assign("\"$sortColumn\"", $sort++)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NoLdman