chore: remove osano styles #4767
Conversation
pepopowitz
added
the
component:docs
|
@antantunes please let me know if there's a specific date I should merge/release this. |
| @@ -328,7 +328,7 @@ module.exports = { | |||
| href: "https://legal.camunda.com/privacy-and-data-protection", | |||
| }, | |||
| { | |||
| html: `<a class="osano-footer-link-docu" href="#" onclick="Osano.cm.showDrawer('osano-cm-dom-info-dialog-open')">Cookie Preferences</a>`, | |||
| html: `<a class="footer__link-item" href="#" onclick="Osano.cm.showDrawer('osano-cm-dom-info-dialog-open')">Cookie Preferences</a>`, | |||
There was a problem hiding this comment.
this is the CSS class that all the other footer links are using, which looks the same.
|
@pepopowitz There is not specific date. Whenever you can. Do not change that part of the code. The code to be deleted is everything after /* Osano Styles */ |
In this comment you stated that the CSS class I removed is only there for visual reasons. I agree with that assessment. If that is the case, then as the owner of docs infrastructure, I would rather remove that unnecessary class in favor of one that the rest of the docs use. Unless there is a reason on the Osano side for that class to exist, this is my decision to make. |
|
@antantunes are you interested in this shipping soon? If so, I'm anticipating a review & approval from you before I merge it. |
|
Hi @pepopowitz, yes as soon as you can. Would you be able to apply the change in staging so I can preview? |
|
I'm unable to deploy to staging until it is merged, however when this comment is updated to contain a preview link, you can preview the site there. |
|
The preview environment relating to the commit e764db2 has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-4767/index.html |
|
The preview environment is now available, @antantunes. |
Description
Closes #4701.
Removes the Osano styles, so that they can be customized on a third party platform.
When should this change go live?
holdlabel or convert to draft PR)PR Checklist
/versioned_docsdirectory./docsdirectory (aka/next/).My changes require an Engineering review, and I've assigned the Engineering DRI or delegate.
My changes require a technical writer review, and I've assigned @camunda/tech-writers as a reviewer.
My changes require a docs infrastructure review.