Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6: Migrate components to OnPush strategy (next branch) #3066

Open
32 tasks
Akshat55 opened this issue Nov 20, 2024 · 1 comment
Open
32 tasks

v6: Migrate components to OnPush strategy (next branch) #3066

Akshat55 opened this issue Nov 20, 2024 · 1 comment
Labels
CCA@v6 help wanted Good for outside contribution

Comments

@Akshat55
Copy link
Contributor

Akshat55 commented Nov 20, 2024 •
edited
Loading

As of now, only a few components support OnPush strategy, most components should be fairly straight forward to migrate. There is a likely hood of Angular moving away from zone.js in future releases, this step allows us to move closer to zone-less.

Components to migrate:

  • Accordion
  • Breadcrumb
  • Button (icon)
  • Combobox
  • Content switcher
  • Context-menu
  • Date picker
  • Datepicker input
  • Dropdown
  • File uploader
  • Inline loading
  • Input (Input/Password/Textarea)
  • Loading
  • Modal
  • Notification
  • Number Input
  • Pagination
  • progress bar
  • Progress Indicator
  • Radio
  • Search
  • Select
  • Slider (Possible rewrite)
  • Table
  • Tabs (Possible rewrite)
  • Tag
  • Tiles
  • Time picker
  • Time picker select
  • Toggle
  • Treeview
  • UI-shell

Since many components are going to be straight forward, we will accept batch PRs.
@Akshat55 Akshat55 added CCA@v6 help wanted Good for outside contribution labels Nov 20, 2024
@Akshat55 Akshat55 moved this to Featured in Carbon Components Angular Nov 21, 2024
@Akshat55 Akshat55 changed the title v6: Migrate components to OnPush strategy v6: Migrate components to OnPush strategy (next branch) Nov 21, 2024
@eduardmarcinco eduardmarcinco mentioned this issue Dec 15, 2024
Merged
@eduardmarcinco
Copy link
Contributor

Checkbox component is already using on push strategy.

carbon-components-angular/src/checkbox/checkbox.component.ts

Line 72 in 5c03216

changeDetection: ChangeDetectionStrategy.OnPush

@eduardmarcinco eduardmarcinco mentioned this issue Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CCA@v6 help wanted Good for outside contribution
Projects
Carbon Components Angular
Status: Featured
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eduardmarcinco @Akshat55