Fix rendering of kapp examples #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carvel canceled.
|
Zebradil
force-pushed
the
fix-kapp-examples-rendering
branch
from
d29261e to
6834c1f
Compare
Signed-off-by: German Lashevich <[email protected]>
|
@Zebradil Do you have an example of how it would look like with these changes. Apparently the deploy-preview is failing stating that it didn't detect any content change, not sure why. |
|
@praveenrewar Notice the alignment yaml node under Before
After
|
praveenrewar
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, removing spaces in front of the opening
highlightshortcodes fixes indentation issues in yaml.This seems like a bug in
hugobut I haven't checked yet. I also looked for the other places where the shortcode is placed past the beginning of the line, but there yaml is rendered correctly.