Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch from private git repo requires write token permission #1262

Closed
jorgemoralespou opened this issue Jul 3, 2023 · 3 comments
Closed

Fetch from private git repo requires write token permission #1262

jorgemoralespou opened this issue Jul 3, 2023 · 3 comments
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed

Comments

@jorgemoralespou
Copy link

What steps did you take:
I have an app that fetches from a private GH repo. For this I have created a token with read-only permissions to content in GH Application Token generation.

What happened:
The app fails to fetch with:

Git [fetch origin]: exit status 128 (stderr: remote: Write access to repository not granted

What did you expect:
Successful fetch

Anything else you would like to add:
Haven't tested this in vendir, as I'm using kapp-controller and that's where I need this to work. Latest vendir is some versions ahead.

Environment:

  • kapp Controller version (execute kubectl get deployment -n kapp-controller kapp-controller -o yaml and the annotation is kbld.k14s.io/images): 0.45.0 from cluster essentials from TMC
  • Kubernetes version (use kubectl version): 1.25.9

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@jorgemoralespou jorgemoralespou added bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity labels Jul 3, 2023
@carvel-bot carvel-bot added this to Carvel Jul 3, 2023
@100mik
Copy link
Contributor

100mik commented Jul 5, 2023

I am going to try and reproduce this with vendir, we might want to move it to carvel-dev/vendir if this is a vendir issue.
Thanks for the callout @jorgemoralespou !

@100mik 100mik added carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity labels Jul 5, 2023
@renuy renuy moved this to To Triage in Carvel Jul 10, 2023
@rcmadhankumar
Copy link
Contributor

  1. Created a Private GH repository contains a simple app

  2. Created a personal access token(new fine grained personal access token) for the selected simple-app-repo, has the permission Content: Read-Only and Metadata: Read-Only (it is mandatory to give readonly permission for metadata)

  3. Created a Package CR that fetches this GitHub app(fetch url is in the format https://username:[email protected]/username/simple-app-repo.git

  4. Created a package install for the same

  5. Deployed the package installs in the below versions of kapp controller

    • v0.45.0
    • v0.45.4
    • latest

The issue is not seen in the above mentioned versions.
Also tried to reproduce with the latest vendor version, issue is not seen there as well.

@jorgemoralespou
Copy link
Author

Reproduced myself as well and worked with current versions, so closing it.

@github-project-automation github-project-automation bot moved this from To Triage to Closed in Carvel Nov 6, 2023
@github-actions github-actions bot added carvel-triage This issue has not yet been reviewed for validity and removed carvel-triage This issue has not yet been reviewed for validity labels Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel-accepted This issue should be considered for future work and that the triage process has been completed
Projects
Archived in project
Development

No branches or pull requests

3 participants