Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueueDuplicateHandlingMode extra option to always add #295

Open
PonchoPowers opened this issue Nov 16, 2020 · 3 comments
Open

QueueDuplicateHandlingMode extra option to always add #295

PonchoPowers opened this issue Nov 16, 2020 · 3 comments

Comments

@PonchoPowers
Copy link

Are you okay with me sending a pull request to make a slight change to the way duplicates are handled? I'm using CruiseControl.NET in a slightly different way to the convention and rather than patching each update it would be much easier if I could make a slight code change that will benefit the community that also makes sense to offer as an option.

In IntegrationQueue.cs there is a swtich that handles duplicates, and I'd like to change the switch so that there is another option:
QueueDuplicateHandlingMode.AddAdditional

This will allow people to force multiple builds as opposed to one, which in my scenario makes sense.

If you are okay with me making this change I'll create a pull request?

By adding a new handling mode the original functionality is retained but an additional option is provided so that I can use CruiseControl.NET in a more useful way.

@PonchoPowers
Copy link
Author

There is also a bug with the ccnet.xsd with ApplyForceBuildsReAddTop being missing which I can fix in the PR.

@RubenWillems
Copy link
Member

RubenWillems commented Nov 16, 2020 via email

@RubenWillems
Copy link
Member

RubenWillems commented Nov 16, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants