-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QueueDuplicateHandlingMode extra option to always add #295
Comments
There is also a bug with the ccnet.xsd with ApplyForceBuildsReAddTop being missing which I can fix in the PR. |
Hi
sure an extra option is the preferred way,
the default value should stay the same as it is now
with kind regards
Ruben Willems
…On Mon, 16 Nov 2020 at 06:06, Matthew Bonner ***@***.***> wrote:
Are you okay with me sending a pull request to make a slight change to the
way duplicates are handled? I'm using CruiseControl.NET in a slightly
different way to the convention and rather than patching each update it
would be much easier if I could make a slight code change that will benefit
the community that also makes sense to offer as an option.
In IntegrationQueue.cs there is a swtich that handles duplicates, and I'd
like to change the switch so that there is another option:
QueueDuplicateHandlingMode.AddAdditional
This will allow people to force multiple builds as opposed to one, which
in my scenario makes sense.
If you are okay with me making this change I'll create a pull request?
By adding a new handling mode the original functionality is retained but
an additional option is provided so that I can use CruiseControl.NET in a
more useful way.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#295>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEUZAO4YKPPHAIEI3HLLADSQCXL3ANCNFSM4TWWHNWQ>
.
|
Hi
If this bug has nothing to do with that new option, make a new pull request.
with kind regards
Ruben Willems
…On Mon, 16 Nov 2020 at 06:13, Matthew Bonner ***@***.***> wrote:
There is also a bug with the ccnet.xsd with ApplyForceBuildsReAddTop being
missing which I can fix in the PR.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#295 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEUZALQ2HSZAFEOIJZJHULSQCYI7ANCNFSM4TWWHNWQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Are you okay with me sending a pull request to make a slight change to the way duplicates are handled? I'm using CruiseControl.NET in a slightly different way to the convention and rather than patching each update it would be much easier if I could make a slight code change that will benefit the community that also makes sense to offer as an option.
In IntegrationQueue.cs there is a swtich that handles duplicates, and I'd like to change the switch so that there is another option:
QueueDuplicateHandlingMode.AddAdditional
This will allow people to force multiple builds as opposed to one, which in my scenario makes sense.
If you are okay with me making this change I'll create a pull request?
By adding a new handling mode the original functionality is retained but an additional option is provided so that I can use CruiseControl.NET in a more useful way.
The text was updated successfully, but these errors were encountered: