Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent heuristic results from VecGeom polycone #1570

Open
mrguilima opened this issue Jan 9, 2025 · 0 comments
Open

Inconsistent heuristic results from VecGeom polycone #1570

mrguilima opened this issue Jan 9, 2025 · 0 comments
Labels
bug Something isn't working geometry Geometry-related features

Comments

@mrguilima
Copy link
Contributor

The test celeritas/geo_Geometry test fails for Cmse geometry, because results are different from different CI platforms.

In some cases, build-docker (vecgeom-*-rocky-cuda) shows these errors:

[----------] 2 tests from CmseTest
[ RUN      ] CmseTest.host
/__w/celeritas/celeritas/test/celeritas/geo/HeuristicGeoTestBase.cc:72: Failure
Values in: avg_path
 Expected: ref_path
2 of 18 elements differ
by 0.0050000000000000001 relative error or 5.0000000000000002e-05 absolute error
 i            ref_path           avg_path         Difference
 1    13.9060168654525    13.4613848262866 -0.0319740759318717
14    225.390314534812    226.528020448795  0.0050477143009927

while in other cases, build-spack (vecgeom-g4@11.*) shows these errors:

/home/runner/work/celeritas/celeritas/test/celeritas/geo/HeuristicGeoTestBase.cc:72
Values in: avg_path
 Expected: ref_path
2 of 18 elements differ
by 0.0050000000000000001 relative error or 5.0000000000000002e-05 absolute error
 i            ref_path           avg_path         Difference
 1        13.461384826    13.9060168654525  0.0330301856161009
14        226.52802045    225.390314534812 -0.00502236285351153

The whole CmseTest host fixture has been temporarily disabled until this can be understood and properly handled.

mrguilima added a commit to mrguilima/celeritas that referenced this issue Jan 9, 2025
@sethrj sethrj added bug Something isn't working geometry Geometry-related features labels Jan 10, 2025
@sethrj sethrj changed the title celeritas/geo_Geometry test fails in CmseTest host Inconsistent heuristic results from VecGeom polycone Jan 10, 2025
sethrj added a commit that referenced this issue Jan 10, 2025
)

* Fix expected volumes and safety values in Vecgeom.test.cc
* Revert "REVERTME: disable failing vecgeom tests"
* Fix build when +vecgeom~geant4
* Fix SolidsGeantTest*
* Fix test Geometry:CmseTest*
* Fix geometry tests for VecGeom's master branch
* Attempt to fix Geometry test, failing at the CI
* Temporarily disable Geometry test for Cmse (host fixture): See issue #1570 for more details.

---------

Co-authored-by: Seth R Johnson <[email protected]>
esseivaju pushed a commit to esseivaju/celeritas that referenced this issue Jan 10, 2025
…leritas-project#1552)

* Fix expected volumes and safety values in Vecgeom.test.cc
* Revert "REVERTME: disable failing vecgeom tests"
* Fix build when +vecgeom~geant4
* Fix SolidsGeantTest*
* Fix test Geometry:CmseTest*
* Fix geometry tests for VecGeom's master branch
* Attempt to fix Geometry test, failing at the CI
* Temporarily disable Geometry test for Cmse (host fixture): See issue celeritas-project#1570 for more details.

---------

Co-authored-by: Seth R Johnson <[email protected]>
sethrj added a commit to sethrj/celeritas that referenced this issue Jan 14, 2025
…leritas-project#1552)

* Fix expected volumes and safety values in Vecgeom.test.cc
* Revert "REVERTME: disable failing vecgeom tests"
* Fix build when +vecgeom~geant4
* Fix SolidsGeantTest*
* Fix test Geometry:CmseTest*
* Fix geometry tests for VecGeom's master branch
* Attempt to fix Geometry test, failing at the CI
* Temporarily disable Geometry test for Cmse (host fixture): See issue celeritas-project#1570 for more details.

---------

Co-authored-by: Seth R Johnson <[email protected]>
sethrj added a commit to sethrj/celeritas that referenced this issue Jan 14, 2025
…leritas-project#1552)

* Fix expected volumes and safety values in Vecgeom.test.cc
* Revert "REVERTME: disable failing vecgeom tests"
* Fix build when +vecgeom~geant4
* Fix SolidsGeantTest*
* Fix test Geometry:CmseTest*
* Fix geometry tests for VecGeom's master branch
* Attempt to fix Geometry test, failing at the CI
* Temporarily disable Geometry test for Cmse (host fixture): See issue celeritas-project#1570 for more details.

---------

Co-authored-by: Seth R Johnson <[email protected]>
sethrj added a commit that referenced this issue Jan 14, 2025
)

* Fix expected volumes and safety values in Vecgeom.test.cc
* Revert "REVERTME: disable failing vecgeom tests"
* Fix build when +vecgeom~geant4
* Fix SolidsGeantTest*
* Fix test Geometry:CmseTest*
* Fix geometry tests for VecGeom's master branch
* Attempt to fix Geometry test, failing at the CI
* Temporarily disable Geometry test for Cmse (host fixture): See issue #1570 for more details.

---------

Co-authored-by: Seth R Johnson <[email protected]>
sethrj added a commit that referenced this issue Jan 14, 2025
)

* Fix expected volumes and safety values in Vecgeom.test.cc
* Revert "REVERTME: disable failing vecgeom tests"
* Fix build when +vecgeom~geant4
* Fix SolidsGeantTest*
* Fix test Geometry:CmseTest*
* Fix geometry tests for VecGeom's master branch
* Attempt to fix Geometry test, failing at the CI
* Temporarily disable Geometry test for Cmse (host fixture): See issue #1570 for more details.

---------

Co-authored-by: Seth R Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working geometry Geometry-related features
Projects
None yet
Development

No branches or pull requests

2 participants