Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Wrap codechecks server calls in try/catch blocks #168

Closed
cgewecke opened this issue Jul 29, 2019 · 8 comments
Closed

Wrap codechecks server calls in try/catch blocks #168

cgewecke opened this issue Jul 29, 2019 · 8 comments

Comments

@cgewecke
Copy link
Owner

See gnosis-hg 58,

Travis error log

@cgewecke
Copy link
Owner Author

cgewecke commented Jul 30, 2019

@krzkaczor Hi:)

gnosis/conditional-token-contracts is using codechecks w/ gas-reporter and getting a 500 server error (on the .success step I think). Can you see anything in the server logs on your side about this?

3.87s$ npx codechecks
CodeChecks Client v.0.1.5
https://codechecks.io
Executing 1 codechecks files
Base branch: d7ba7a2f
Executing codechecks.yml...
Error occured:  500 - {"statusCode":500,"message":"Internal server error"}

It possible I broke something here but am getting normal results in all my tests ... e.g have added codechecks to CI and get a report w/out problems

@krzkaczor
Copy link
Contributor

Hey!
I am on it. Generally, it's related to the fact that once in a while GitHub API is not accessible.

I hope that today I will come up with good error handling/retry strategy. I will keep you posted.

@cgewecke
Copy link
Owner Author

@krzkaczor Ah cool! Thanks!

@krzkaczor
Copy link
Contributor

I just pushed the fix (and improved logging ;)) to production. Could you let me know if it helps @cgewecke

@cgewecke
Copy link
Owner Author

Yes I will, thanks so much @krzkaczor!

Closing here because resolved by #170 / 0.2.9

@cgewecke
Copy link
Owner Author

@krzkaczor In the end gnosis's problem might be that they renamed their repo. Idk, anyway it works again now after turning project on/off in the codechecks UI.

Thanks again for looking into this...

@krzkaczor
Copy link
Contributor

@cgewecke fyi: i deployed multiple stability fixes over the weekend — random 500s should be gone now.

@cgewecke
Copy link
Owner Author

cgewecke commented Aug 5, 2019

Thanks @krzkaczor!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants