[Build]: MacOS Build fails in CI

[ShortDevelopment]

Operating System

MacOS in our CI

Compiler

Xcode 16.1 / 15.4

ChakraCore Version

main

Compiler output

In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/functional:521:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/__functional/bind.h:20:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/tuple:1455:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/exception:82:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/__exception/exception_ptr.h:16:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/__memory/construct_at.h:23:
/Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/new:285:35: error: redefinition of 'operator delete'
  285 | inline _LIBCPP_HIDE_FROM_ABI void operator delete(void*, void*) _NOEXCEPT {}
      |                                   ^
/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Common/Memory/Allocator.h:466:1: note: previous definition is here
  466 | operator delete(
      | ^
2 errors generated.
[193/540] Building CXX object lib/Parser/CMakeFiles/Chakra.Parser.dir/CharSet.cpp.o
FAILED: lib/Parser/CMakeFiles/Chakra.Parser.dir/CharSet.cpp.o 
/usr/bin/clang++ -DBIT64=1 -DCHAKRA_STATIC_LIBRARY=1 -DCLANG_HAS_DISABLE_TAIL_CALLS=1 -DDISABLE_JIT=1 -DFEATURE_PAL -DHAS_ICU -DHAS_REAL_ICU=1 -DINTL_ICU=1 -DNO_PAL_MINMAX -DPAL_STDCPP_COMPAT -DPLATFORM_UNIX -DPLATFORM_UNIX=1 -DSTACK_ALIGN=16 -DTARGET_64 -DUNICODE -D_ARM64_ -D_ARM64_=1 -D_CHAKRACOREBUILD -D_M_ARM32_OR_ARM64 -D_M_ARM64 -D_SAFECRT_USE_CPP_OVERLOADS=1 -D__STDC_WANT_LIB_EXT1__=1 -D__aarch64__ -D__arm64__=1 -I/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/. -I/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Common -I/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Common/PlaceHolder -I/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/pal -I/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/pal/inc -I/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/pal/inc/rt -I/opt/homebrew/opt/icu4c/include -I/opt/homebrew/opt/icu4c/include/../i18n -I/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser -I/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../JITIDL -I/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../Common -I/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../Backend -I/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../Runtime -I/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../Runtime/ByteCode -isystem /usr/local/include -mmacosx-version-min=10.9 -std=gnu++11         -Wno-ignored-attributes        -Wno-parentheses-equality        -Wno-reorder        -Wno-microsoft        -Wno-unused-value        -Wno-int-to-void-pointer-cast        -Wno-invalid-offsetof        -Wno-undefined-inline        -Wno-inconsistent-missing-override        -Wno-c++14-extensions        -Wno-macro-redefined        -Wno-pragmas        -Wno-invalid-token-paste        -Wno-format        -Wno-invalid-noreturn        -Wno-null-arithmetic        -Wno-tautological-constant-out-of-range-compare        -Wno-tautological-undefined-compare        -Wno-address-of-temporary        -Wno-null-conversion        -Wno-return-type        -Wno-switch        -Wno-int-to-pointer-cast        -Wno-tautological-constant-compare        -Wno-enum-compare-switch        -Wno-unknown-warning-option         -Werror         -Wno-error                  -fno-omit-frame-pointer         -fdelayed-template-parsing -O3 -DNDEBUG -std=gnu++11 -arch arm64 -isysroot /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk -mmacosx-version-min=14.6   -fdiagnostics-color=always -arch arm64 -mmacosx-version-min=10.9 -fasm-blocks -fms-extensions -fwrapv -fno-rtti -fPIC -MD -MT lib/Parser/CMakeFiles/Chakra.Parser.dir/CharSet.cpp.o -MF lib/Parser/CMakeFiles/Chakra.Parser.dir/CharSet.cpp.o.d -o lib/Parser/CMakeFiles/Chakra.Parser.dir/CharSet.cpp.o -c /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/CharSet.cpp
In file included from /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/CharSet.cpp:5:
In file included from /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/ParserPch.h:22:
In file included from /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../Runtime/Runtime.h:334:
In file included from /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../Runtime/PlatformAgnostic/ChakraPlatform.h:7:
In file included from /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../Runtime/PlatformAgnostic/UnicodeText.h:8:
In file included from /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../Runtime/PlatformAgnostic/ChakraICU.h:38:
In file included from /opt/homebrew/opt/icu4c/include/unicode/ucol.h:1524:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/functional:521:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/__functional/bind.h:20:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/tuple:1455:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/exception:82:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/__exception/exception_ptr.h:16:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/__memory/construct_at.h:23:
/Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/new:279:66: error: redefinition of 'operator new'
  279 | _LIBCPP_NODISCARD_AFTER_CXX17 inline _LIBCPP_HIDE_FROM_ABI void* operator new(std::size_t, void* __p) _NOEXCEPT {
      |                                                                  ^
/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Common/Memory/Allocator.h:457:1: note: previous definition is here
  457 | operator new(
      | ^
In file included from /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/CharSet.cpp:5:
In file included from /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/ParserPch.h:22:
In file included from /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../Runtime/Runtime.h:334:
In file included from /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../Runtime/PlatformAgnostic/ChakraPlatform.h:7:
In file included from /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../Runtime/PlatformAgnostic/UnicodeText.h:8:
In file included from /private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Parser/../Runtime/PlatformAgnostic/ChakraICU.h:38:
In file included from /opt/homebrew/opt/icu4c/include/unicode/ucol.h:1524:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/functional:521:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/__functional/bind.h:20:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/tuple:1455:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/exception:82:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/__exception/exception_ptr.h:16:
In file included from /Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/__memory/construct_at.h:23:
/Applications/Xcode_16.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/include/c++/v1/new:285:35: error: redefinition of 'operator delete'
  285 | inline _LIBCPP_HIDE_FROM_ABI void operator delete(void*, void*) _NOEXCEPT {}
      |                                   ^
/private/var/folders/xf/_tm0f94d66n8kr12tqwrylrr0000gn/T/cirrus-ci-build/lib/Common/Memory/Allocator.h:466:1: note: previous definition is here
  466 | operator delete(
      | ^
2 errors generated.
ninja: build stopped: subcommand failed.

Additional Context

https://github.com/chakra-core/ChakraCore/runs/34919774427

Azure: Online Logs Raw Download

11a6851
4398657

@ppenzin

[ppenzin]

Looks like cirrus CI provides some of the same functionality in its own headers as XCode

[ShortDevelopment]

The azure builds are failing as well

[ppenzin]

As an aside, we better understand this before CI logs expire :)

[ppenzin]

Azure seems to have the same issue - redefining memory allocation in its headers. Need to figure out what changed - latest xcode or macos made this unnecessary?

[ShortDevelopment]

I'm not sure.

This was the last working version I know.
This one fails only on MacOS (Azure + Cirrus): https://cirrus-ci.com/task/5161225459335168

Note: Both are from my branch but the same build error occurs in the empty PR you just closed
https://cirrus-ci.com/task/5082816231243776