You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As far as I'm aware, there's no universal or obvious way to see git's output when Hoff invokes a a git command and that command fails with an error code. I ran into this when I tried running Hoff with stack run -- config.json after having already set up Hoff once. If Stack's Nix integration is enabled, then this will result the following cryptic error being printed to STDERR and posted as a comment to GitHub:
Failed to rebase, please rebase manually using
git fetch && git rebase --interactive --autosquash origin/master another-fix
In reality, the actual issue was the same issue already documented in the readme where the ssh binary isn't in the search path since stack run by default uses nix-shell --pure. If you ran Hoff this way for the first time you may get a clearer error message indicating that git couldn't find ssh during the original clone, but if the repo is already checked out then you now get this spurious rebase failure error when issuing a merge command. Since git command line failures are either caused by merge conflicts or by actual important errors like these, I think it may make sense to log them directly. Perhaps using a log level that can be disabled in production if merge conflict messages end up taking up too much logging bandwidth (don't think that would be an actual issue though).
Any thoughts?
The text was updated successfully, but these errors were encountered:
As far as I'm aware, there's no universal or obvious way to see git's output when Hoff invokes a a git command and that command fails with an error code. I ran into this when I tried running Hoff with
stack run -- config.json
after having already set up Hoff once. If Stack's Nix integration is enabled, then this will result the following cryptic error being printed to STDERR and posted as a comment to GitHub:In reality, the actual issue was the same issue already documented in the readme where the
ssh
binary isn't in the search path sincestack run
by default usesnix-shell --pure
. If you ran Hoff this way for the first time you may get a clearer error message indicating that git couldn't findssh
during the original clone, but if the repo is already checked out then you now get this spurious rebase failure error when issuing a merge command. Since git command line failures are either caused by merge conflicts or by actual important errors like these, I think it may make sense to log them directly. Perhaps using a log level that can be disabled in production if merge conflict messages end up taking up too much logging bandwidth (don't think that would be an actual issue though).Any thoughts?
The text was updated successfully, but these errors were encountered: