You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #272 I decided to send a reaction only if the PR in question is the first to be merged, so that we do still provide the position in the merge queue otherwise. But it's annoying that this still leads to an unnecessary ping:
It would be better if Hoff just reacts with 👍 in this case as well, and in addition sends a message just stating the position in the queue ("Waiting for rebase behind N pull requests...").
The Feedback type would probably have to be modified to allow a reaction and a comment, or something else in the logic loop would have to change so that we also go back and send a comment in a separate step.
The text was updated successfully, but these errors were encountered:
in addition sends a message just stating the position in the queue ("Waiting for rebase behind N pull requests...").
This might not even be necessary, since (I think) you'll get a speculative rebase in that case, which already results in a message indicating position:
In #272 I decided to send a reaction only if the PR in question is the first to be merged, so that we do still provide the position in the merge queue otherwise. But it's annoying that this still leads to an unnecessary ping:
It would be better if Hoff just reacts with 👍 in this case as well, and in addition sends a message just stating the position in the queue ("Waiting for rebase behind N pull requests...").
The check for the queue position happens here:
hoff/src/Logic.hs
Lines 1189 to 1195 in 43b6787
The
Feedback
type would probably have to be modified to allow a reaction and a comment, or something else in the logic loop would have to change so that we also go back and send a comment in a separate step.The text was updated successfully, but these errors were encountered: