Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Prometheus metrics for Hoff's state #99

Closed
bertptrs opened this issue Jan 26, 2022 · 2 comments
Closed

Expose Prometheus metrics for Hoff's state #99

bertptrs opened this issue Jan 26, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bertptrs
Copy link

Currently the only way to gain insight into the state of Hoff is to look at its public status pages. This can be used for debugging but it cannot really provide insight long term. I think it would be nice to have some metrics, in a Prometheus-compatible format, about what Hoff is doing and what it has done.

Some per-project metrics come to mind:

  • number of PRs processed (counter)
  • number of PRs merged (counter)
  • number of PRs failed' (counter)
  • queue length
  • current build duration (might be more correct to use the starting timestamp of the current build?)

I can think of others which would be fun but not really add value so I've left them out.

I also think it would be useful to have the monitoring endpoint listen on an alternate port from the main HTTP port, so we can separate traffic and firewall things more easily.

@bertptrs bertptrs added enhancement New feature or request good first issue Good for newcomers labels Jan 26, 2022
@diegodiv diegodiv self-assigned this Dec 23, 2022
@ReinierMaas
Copy link

@DiegoDiverio I see you merged a PR related to this issue. Did you complete everything that was specified here?

@diegodiv
Copy link

I split this issue into other issues for the last two metrics of the list:

For the pending PR-related metrics, we can reopen an issue, making clear what the behaviour of each metric would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants