Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property Checkout\Payments\Sessions\PaymentSessionsRequest::$three_ds (Checkout\Payments\Sessions\ThreeDsRequest) does not accept Checkout\Payments\ThreeDsRequest. #258

Closed
ekomino opened this issue Jun 26, 2024 · 0 comments · Fixed by #271
Assignees
Labels
bug Something isn't working

Comments

@ekomino
Copy link

ekomino commented Jun 26, 2024

Environment

  • Checkout SDK version: 3.2.0
  • Platform and version:
  • Operating System and version: MacOS

Description

After upgrading from 3.1.0 to 3.2.0, PaymentSessionsRequest is throwing an error as the $three_ds param is expecting Checkout\Payments\Sessions\ThreeDsRequest which doesn't exist.

Expected behavior

Param $three_ds should accept Checkout\Payments\ThreeDsRequest as param type.

Current behavior

Property Checkout\Payments\Sessions\PaymentSessionsRequest::$three_ds (Checkout\Payments\Sessions\ThreeDsRequest) does not accept Checkout\Payments\ThreeDsRequest. 

Steps to reproduce

Create a new $threeDs object and include it in the PaymentSessionRequest:

$threeDs = new ThreeDsRequest();

$paymentSessionRequest = new PaymentSessionsRequest();
$paymentSessionRequest->three_ds = $threeDs;

Possible solution

Specify the correct path for the params type, or if needed, implement the new classes inside the \Checkout\Payments\Sessions\Sessions folder.

Additional information

There might be some other cases in the PaymentSessionRequest class that might have the same issue, like:

  • $expires_on
  • $risk
  • $retry
  • $sender
@armando-rodriguez-cko armando-rodriguez-cko self-assigned this Jul 1, 2024
@armando-rodriguez-cko armando-rodriguez-cko added the bug Something isn't working label Jul 1, 2024
@armando-rodriguez-cko armando-rodriguez-cko linked a pull request Oct 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants