Quickstart Guide should not create a self-signed certificate if a CertificateThumbprint is passed #281
Comments
JPRuskin
added a commit
that referenced
this issue
Nov 25, 2024
The Chocolatey-Management-Service package generates a self-signed certificate to use if no thumbprint is specified as a parameter. Regardless of if a certificate was specified, we were installing it without a thumbprint and then setting the certificate later. This resulted in an unused self-signed certificate being generated and stored. This change ensures the package gets the appropriate parameter in order to not generate unneeded certificate(s).
3 tasks
JPRuskin
added a commit
that referenced
this issue
Dec 13, 2024
The Chocolatey-Management-Service package generates a self-signed certificate to use if no thumbprint is specified as a parameter. Regardless of if a certificate was specified, we were installing it without a thumbprint and then setting the certificate later. This resulted in an unused self-signed certificate being generated and stored. This change ensures the package gets the appropriate parameter in order to not generate unneeded certificate(s).
JPRuskin
added a commit
that referenced
this issue
Jan 8, 2025
The Chocolatey-Management-Service package generates a self-signed certificate to use if no thumbprint is specified as a parameter. Regardless of if a certificate was specified, we were installing it without a thumbprint and then setting the certificate later. This resulted in an unused self-signed certificate being generated and stored. This change ensures the package gets the appropriate parameter in order to not generate unneeded certificate(s).
JPRuskin
added a commit
that referenced
this issue
Jan 9, 2025
The Chocolatey-Management-Service package generates a self-signed certificate to use if no thumbprint is specified as a parameter. Regardless of if a certificate was specified, we were installing it without a thumbprint and then setting the certificate later. This resulted in an unused self-signed certificate being generated and stored. This change ensures the package gets the appropriate parameter in order to not generate unneeded certificate(s).
JPRuskin
added a commit
that referenced
this issue
Jan 9, 2025
Having CertificateThumbprint and Thumbprint treated differently across the scripts is annoying, and can introduce confusion. This change brings all the scripts into the same $Thumbprint (with an alias for folk who instinctively use CertificateThumbprint), and an argument completer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Is Your Feature Request Related To A Problem? Please describe.
If running QSG, a self-signed certificate is generated during the install of Chocolatey-Management-Service regardless of if a CertificateThumbprint is passed in to the scripts.
Describe The Solution. Why is it needed?
Having an additional (unused) certificate on the system adds confusion and an additional point of failure.
Additional Context
Currently, the code is installing the package the same way but calling Set-CCMCertificate if there's a thumbprint passed. The package creates a certificate if no thumbprint is passed to it. We should pass the thumbprint in to the package.
Related Issues
No response
The text was updated successfully, but these errors were encountered: