Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add per-launch-file arguments to YAML files #135

Open
tobiasduerschmid opened this issue Jul 26, 2021 · 0 comments
Open

Add per-launch-file arguments to YAML files #135

tobiasduerschmid opened this issue Jul 26, 2021 · 0 comments
Assignees
@tobiasduerschmid
Labels
enhancement New feature or request

Comments

@tobiasduerschmid
Copy link
Collaborator

tobiasduerschmid commented Jul 26, 2021 •
edited
Loading

For launch files that include other launch files using arguments, such as: <include file="$(arg tf_launch)"/> we need to specify these arguments for rosdiscoverer to pass it to roslaunch.
To this end, we need to change the YAML of the launches tag to include a list of objects instead of just a list of strings
@tobiasduerschmid tobiasduerschmid added the enhancement New feature or request label Jul 26, 2021
@tobiasduerschmid tobiasduerschmid self-assigned this Jul 26, 2021
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Add launch class (#135)
e874c0a
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Read launch arguments in Config (#135)
cc6f48d
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Small fixes (#135)
bee5afd
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Fix launch parser (#135)
44e6267
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Fix get_argv (#135)
7c3de32
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Improve the format checking (#135)
c17d45f
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Adjust data type of launches_inputs (#135)
418ff84
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Use snake case (#135)
f0b5734
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Add class comment for Launch (#135)
11a545b
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Fix launch_args_provided (#135)
aa17509
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Add return type annotation to get_argv (#135)
cf0cbbb
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Remove debug log (#135)
351a999
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Remove __attrs_post_init__ (#135)
5127ae1
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Reformat imports_ (#135)
6d44812
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Fix tox issues (#135)
37d7deb
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Fix types (#135)
e1bf872
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Revert accidential tox change (#135)
61a0020
tobiasduerschmid added a commit that referenced this issue Jul 26, 2021
@tobiasduerschmid
Fix typing (#135)
75efe56
tobiasduerschmid added a commit that referenced this issue Aug 3, 2021
@tobiasduerschmid
Fix formatting issues #135
11aa30b
tobiasduerschmid added a commit that referenced this issue Aug 3, 2021
@tobiasduerschmid
Fix formatting issues #135
c5749e7
tobiasduerschmid added a commit that referenced this issue Aug 4, 2021
@tobiasduerschmid
Add new line in imports (#135)
75764f1
tobiasduerschmid added a commit that referenced this issue Aug 4, 2021
@tobiasduerschmid
Rename launch_obj to launch_description (#135)
c5fe925
tobiasduerschmid added a commit that referenced this issue Aug 4, 2021
@tobiasduerschmid
Move class comment to doc string (#135)
da280c9
tobiasduerschmid added a commit that referenced this issue Aug 4, 2021
@tobiasduerschmid
Fix file name lookup (#135)
e005b85
ChrisTimperley pushed a commit that referenced this issue Aug 4, 2021
@tobiasduerschmid
Add launch file arguments to YML files (#141)
e5a14f8 
* Add launch class (#135)

* Read launch arguments in Config  (#135)

* Small fixes (#135)

* Fix launch parser (#135)

* Fix get_argv (#135)

* Improve the format checking (#135)

* Adjust data type of launches_inputs (#135)

* Use snake case (#135)

* Add class comment for Launch (#135)

* Fix launch_args_provided (#135)

* Use list comprehension

* Add return type annotation to get_argv (#135)

* Remove debug log (#135)

* Remove __attrs_post_init__ (#135)

* Reformat imports_ (#135)

* Fix tox issues (#135)

* Fix types (#135)

* Revert accidential tox change (#135)

* Fix typing (#135)

* Update README.rst

* Fix formatting issues #135

* Fix typig of Any

* Add new line in imports (#135)

* Rename launch_obj to launch_description (#135)

* Move class comment to doc string (#135)

* Fix file name lookup (#135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiasduerschmid tobiasduerschmid

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tobiasduerschmid