Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FInding nodelets by class name #510

Open
schmerl opened this issue Nov 1, 2021 · 1 comment
Open

FInding nodelets by class name #510

schmerl opened this issue Nov 1, 2021 · 1 comment

Comments

@schmerl
Copy link
Collaborator

schmerl commented Nov 1, 2021

The way that nodelets are resolved is quite tricky. You can load them using the name of the class, but you don't know the name of the class until you parse the source, which we do after trying to find them. For the moment in:

What really needs to be done is to look through all the source files in info.targets to find which info.target defines the class in library.name or library.type, then add that target keyed by the type as well. This is needed because nodelets can be loaded into managers by their class name.

But probably the whole nodelet resolution architecture needs to be rethought.

@schmerl
Copy link
Collaborator Author

schmerl commented Nov 1, 2021

There is a workaround in: #509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant