Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] cnf_setup should support custom file names #1429

Open
denverwilliams opened this issue May 4, 2022 · 3 comments
Open

[FEATURE] cnf_setup should support custom file names #1429

denverwilliams opened this issue May 4, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@denverwilliams
Copy link
Collaborator

denverwilliams commented May 4, 2022

Describe the bug
The cnf_setup command only works if the configuration file used in is named exactly cnf-testsuite.yml If a different filename is used the installation will fail.

e.g
Working example: ./cnf-testsuite -l info cnf_setup cnf-config=./cnf-testsuite.yml

Failing example ./cnf-testsuite -l info cnf_setup cnf-config=./cnf-testsuite-test.yml

Currently affecting all installation methods:

  • helm_chart
  • manifest_directory
  • helm_directory

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Device (please complete the following information):

  • OS [e.g. Linux, iOS, Windows, Android]
  • Distro [e.g. Ubuntu]
  • Version [e.g. 18.04]
  • Architecture [e.g. x86, arm]
  • Browser [e.g. chrome, safari]

How will this be tested? aka Acceptance Criteria (optional)

(optional: unnecessary for things like spelling errors and such)

Once this issue is address how will the fix be verified?

Additional context
Add any other context about the problem here.


NOTE: you can enable higher logging level output via the command line or env var. to help with debugging

# cmd line
./cnf-testsuite -l debug test

# make sure to use -- if running from source
crystal src/cnf-testsuite.cr -- -l debug test

# env var
LOGLEVEL=DEBUG ./cnf-testsuite test

Also setting the verbose option for many tasks will add extra output to help with debugging

crystal src/cnf-testsuite.cr test_name verbose

Check usage documentation for more info about invoking commands and logging

@denverwilliams denverwilliams added the bug Something isn't working label May 4, 2022
@denverwilliams denverwilliams self-assigned this May 4, 2022
@kosstennbl
Copy link
Collaborator

Also have met this issue, here's some additional comments to this problem (I've created a duplicate of this issue, copy from there):

cnf-config option can take only files with "cnf-testsuite.yml" name, usage of other filenames causes failures or leads to very unexpected behavior.

Describe the solution you'd like:
Possibility to use different names for cnf config file. Some solution would be needed for constants and "CNFManager.cnf_config_list" function. Easiest one (but not a nice one) would be allowing user to use their config name, but rename it to "cnf-testsuite.yml" on copy to internal cnfs/* directory.

Describe alternatives you've considered:
Leave limitations of config naming as it is now, but give user clear error messages and don't allow him to use any other name for cnf-config parameter. Error should be given at the earliest stages so no actions would be made by the application.

@agentpoyo agentpoyo added enhancement New feature or request and removed bug Something isn't working labels Jan 30, 2024
@agentpoyo agentpoyo changed the title [BUG] Fix cnf_setup so it supports a custom file name [FEATURE] cnf_setup should support custom file names Jan 30, 2024
@agentpoyo
Copy link
Collaborator

This isn't so much a bug, but more of a feature since the original design was to support the cnf-testsuite.yml config name only. Updating this issue to reflect this as a feature over a bug.

@kosstennbl
Copy link
Collaborator

Still relevant. I think that having fixed file name for CNF config is a problem and limitation rather than a feature. Possibly would be fixed somewhere during #2120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Status: Todo
Development

No branches or pull requests

3 participants