Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't double click to change directory without doubling-up the directory path #858

Open
garrett opened this issue Dec 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@garrett
Copy link
Member

garrett commented Dec 5, 2024

Nearly every time I try to change directories, it doubles the path, so "Downloads" becomes "Downloads/Downloads" same for all directories.

image

I find that if I click and wait, sometimes it works as expected.

@garrett
Copy link
Member Author

garrett commented Dec 5, 2024

If I click "back", it goes to the right place, so it looks like it runs go() (or whatever function is used) twice?

I think this is a problem with debouncing (in that it might not be debouncing?).

Note: This is in Firefox.

@jelly
Copy link
Member

jelly commented Dec 5, 2024

Can't reproduce this issue, but I can reproduce that double clicking fast enough makes files go from Downloads to the second folder undernearth.

So there is no debouncing in the doubleclick event listener which might explain your issue.

@jelly jelly added the bug Something isn't working label Dec 5, 2024
@garrett
Copy link
Member Author

garrett commented Dec 5, 2024

It consistently shows up when it shows up here. I was able to reproduce it in Firefox, but couldn't reproduce it in other browsers. But then Firefox sometimes works fine too. (And I can have a consistently broken version in one tab of Firefox and a working one in another tab. Weird, right? 🤔 )

I don't know if I'm double clicking too fast, if my system is running too slow when it happens, or some weird bug is getting in the way.

But adding debouncing should solve it regardless. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants