Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support for topic validation in nemesis changefeed tests #139033

Open
aerfrei opened this issue Jan 14, 2025 · 4 comments
Open

Add better support for topic validation in nemesis changefeed tests #139033

aerfrei opened this issue Jan 14, 2025 · 4 comments
Assignees
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc

Comments

@aerfrei
Copy link
Contributor

aerfrei commented Jan 14, 2025

Right now in nemesis tests when we test changefeeds with the full_table_name option we assume that for a table {foo}, the full table name will be d.public.{foo}. That is to say the values d and public are hardcoded. We should be able to support other values for the db and schema names.

Additionally, we do not test behavior when the user specifies a topic name.

Describe the solution you'd like
If there were a way to both run the test with dbs and schemas with different names and to fetch those at assertion time, that would be ideal.
Also, we should be able to specify a topic name at changefeed creation time and test that it is respected in the topic name validator.

Jira issue: CRDB-46481

@aerfrei aerfrei added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jan 14, 2025
@aerfrei aerfrei self-assigned this Jan 14, 2025
@aerfrei aerfrei added the A-cdc Change Data Capture label Jan 14, 2025
@blathers-crl blathers-crl bot added the T-cdc label Jan 14, 2025
Copy link

blathers-crl bot commented Jan 14, 2025

cc @cockroachdb/cdc

@wenyihu6
Copy link
Contributor

For these new sub-issues, you can link the parent epic to https://cockroachlabs.atlassian.net/browse/CRDB-38724.

@aerfrei
Copy link
Contributor Author

aerfrei commented Jan 14, 2025

@wenyihu6 I'm having trouble connecting it directly, maybe because that's an issue and not an epic. I'm adding it to that issue's parent for now: https://cockroachlabs.atlassian.net/browse/CRDB-42866. Do you know if there's another way to add those to that issue?

@wenyihu6
Copy link
Contributor

Ahh, I didn't realize that the randomized testing one is not an epic. I think what you did is fine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc
Projects
None yet
Development

No branches or pull requests

2 participants