Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvclient: add ability to flush write buffer when it gets too large #139056

Open
arulajmani opened this issue Jan 14, 2025 · 0 comments
Open

kvclient: add ability to flush write buffer when it gets too large #139056

arulajmani opened this issue Jan 14, 2025 · 0 comments
Assignees
@arulajmani
Labels
A-buffered-writes Related to the introduction of buffered writes A-kv-transactions Relating to MVCC and the transactional model. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@arulajmani
Copy link
Collaborator

In service of #72614

We should cap the size we allow the TxnCoordSenders write buffer to get, lest we OOM. The exact size is TBD, but once we hit it, we should flush the buffer.
@arulajmani arulajmani added A-buffered-writes Related to the introduction of buffered writes A-kv-transactions Relating to MVCC and the transactional model. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team labels Jan 14, 2025
@arulajmani arulajmani self-assigned this Jan 14, 2025
@arulajmani arulajmani mentioned this issue Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arulajmani arulajmani

Labels
A-buffered-writes Related to the introduction of buffered writes A-kv-transactions Relating to MVCC and the transactional model. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arulajmani