Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvclient: ship entire write buffer on leaf transcations #139058

Open
arulajmani opened this issue Jan 14, 2025 · 0 comments
Open

kvclient: ship entire write buffer on leaf transcations #139058

arulajmani opened this issue Jan 14, 2025 · 0 comments
Assignees
Labels
A-buffered-writes Related to the introduction of buffered writes A-kv-transactions Relating to MVCC and the transactional model. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@arulajmani
Copy link
Collaborator

In service of #72614

Once we start buffering writes on the client, a leaf transaction that attempts to read-its-own-writes will need access to the buffer as well. As a first step, to ensure correctness, we should ship the entire write buffer on every leaf transaction. In the future, we may then be able to constrain the buffer shipped on leaf transactions to just the span over which the leaf transaction is created.

@arulajmani arulajmani added A-buffered-writes Related to the introduction of buffered writes A-kv-transactions Relating to MVCC and the transactional model. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team labels Jan 14, 2025
@arulajmani arulajmani self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-buffered-writes Related to the introduction of buffered writes A-kv-transactions Relating to MVCC and the transactional model. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
None yet
Development

No branches or pull requests

1 participant