Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: consider improvements on-by-default jemalloc observability #139067

Open
jbowens opened this issue Jan 14, 2025 · 1 comment
Open

storage: consider improvements on-by-default jemalloc observability #139067

jbowens opened this issue Jan 14, 2025 · 1 comment
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team

Comments

@jbowens
Copy link
Collaborator

jbowens commented Jan 14, 2025

In escalations like cockroachlabs/support#3153 where we require observability into jemalloc behavior, we're currently forced to ask users to collect additional jemalloc stats through setting vmodule flags. This back and forth adds latency to our investigations and frustrates users. There's probably something we can do to improve the observability we collect by default that can improve the situation. If I recall correctly, we currently attempt to notice an imminent oom death and dump a Go heap profile to the filesystem. Should we also dump detailed jemalloc stats alongside the heap profile? Are there stats that we can collect periodically without too much overhead.

Jira issue: CRDB-46489

@jbowens jbowens added A-storage Relating to our storage engine (Pebble) on-disk storage. T-storage Storage Team labels Jan 14, 2025
Copy link

blathers-crl bot commented Jan 14, 2025

Hi @jbowens, I've guessed the C-ategory of your issue and suitably labeled it. Please re-label if inaccurate.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-storage Storage Team
Projects
None yet
Development

No branches or pull requests

1 participant