Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: use Pebble-side cockroach key schema implementation #139068

Open
RaduBerinde opened this issue Jan 14, 2025 · 1 comment
Open

storage: use Pebble-side cockroach key schema implementation #139068

RaduBerinde opened this issue Jan 14, 2025 · 1 comment
Assignees
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-storage Storage Team

Comments

@RaduBerinde
Copy link
Member

RaduBerinde commented Jan 14, 2025

We currently maintain two implementations for the Cockroach-specific key schema, the production one in CRDB and a test-only one in Pebble. Keeping them in sync is error-prone and we have found a handful of bugs that were in one or not the other.

This issue tracks using the pebble-side implementation. A blocker for this work was around test-only assertions but we have recently enabled Pebble invariants for all crdb test builds (#138251).

Jira issue: CRDB-46490

@RaduBerinde RaduBerinde added A-storage Relating to our storage engine (Pebble) on-disk storage. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-storage Storage Team labels Jan 14, 2025
@RaduBerinde RaduBerinde self-assigned this Jan 14, 2025
@RaduBerinde
Copy link
Member Author

We want to do this after the 25.1 branch cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Relating to our storage engine (Pebble) on-disk storage. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. T-storage Storage Team
Projects
None yet
Development

No branches or pull requests

1 participant