From e87d61ad4a680ccb5d0fabcdf5dceb2e154ece64 Mon Sep 17 00:00:00 2001 From: Anmol Sethi Date: Sun, 7 Apr 2024 09:12:54 -0700 Subject: [PATCH] Misc fixes for release --- .github/workflows/ci.yml | 8 ++++---- .github/workflows/daily.yml | 8 ++++---- close.go | 2 +- conn_test.go | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3c650580..e9b4b5f6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: actions/setup-go@v4 + - uses: actions/setup-go@v5 with: go-version-file: ./go.mod - run: ./ci/fmt.sh @@ -19,7 +19,7 @@ jobs: steps: - uses: actions/checkout@v4 - run: go version - - uses: actions/setup-go@v4 + - uses: actions/setup-go@v5 with: go-version-file: ./go.mod - run: ./ci/lint.sh @@ -28,7 +28,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: actions/setup-go@v4 + - uses: actions/setup-go@v5 with: go-version-file: ./go.mod - run: ./ci/test.sh @@ -41,7 +41,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: actions/setup-go@v4 + - uses: actions/setup-go@v5 with: go-version-file: ./go.mod - run: ./ci/bench.sh diff --git a/.github/workflows/daily.yml b/.github/workflows/daily.yml index 340de501..2ba9ce34 100644 --- a/.github/workflows/daily.yml +++ b/.github/workflows/daily.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: actions/setup-go@v4 + - uses: actions/setup-go@v5 with: go-version-file: ./go.mod - run: AUTOBAHN=1 ./ci/bench.sh @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: actions/setup-go@v4 + - uses: actions/setup-go@v5 with: go-version-file: ./go.mod - run: AUTOBAHN=1 ./ci/test.sh @@ -34,7 +34,7 @@ jobs: - uses: actions/checkout@v4 with: ref: dev - - uses: actions/setup-go@v4 + - uses: actions/setup-go@v5 with: go-version-file: ./go.mod - run: AUTOBAHN=1 ./ci/bench.sh @@ -44,7 +44,7 @@ jobs: - uses: actions/checkout@v4 with: ref: dev - - uses: actions/setup-go@v4 + - uses: actions/setup-go@v5 with: go-version-file: ./go.mod - run: AUTOBAHN=1 ./ci/test.sh diff --git a/close.go b/close.go index 625ed121..31504b0e 100644 --- a/close.go +++ b/close.go @@ -131,7 +131,7 @@ func (c *Conn) Close(code StatusCode, reason string) (err error) { // CloseNow closes the WebSocket connection without attempting a close handshake. // Use when you do not want the overhead of the close handshake. func (c *Conn) CloseNow() (err error) { - defer errd.Wrap(&err, "failed to close WebSocket") + defer errd.Wrap(&err, "failed to immediately close WebSocket") if !c.casClosing() { err = c.waitGoroutines() diff --git a/conn_test.go b/conn_test.go index 9fbe961d..2b44ad22 100644 --- a/conn_test.go +++ b/conn_test.go @@ -346,7 +346,7 @@ func TestConn(t *testing.T) { func TestWasm(t *testing.T) { t.Parallel() if os.Getenv("CI") == "" { - t.Skip() + t.SkipNow() } s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {