Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Jquery #419

Open
abhishek97 opened this issue May 27, 2019 · 14 comments
Open

Deprecate Jquery #419

abhishek97 opened this issue May 27, 2019 · 14 comments

Comments

@abhishek97
Copy link
Contributor

Jquery was included by default in Ember.js. Though it has served its purpose well, current state of ember and browsers no longer needs Jquery. Ember also has officially deprecated Jquery, we also wish to do the same.

Task: Remove all usages of jQuery throughout the project. One way to get started is to remove @ember/jquery package from package.json and re-rerun yarn install and check for errors due to absence of Jquery and fix them with suitable Vanilla JS / Ember code.

@sourabh1031
Copy link

sourabh1031 commented May 27, 2019

I want to try this. Actually i don't know ember can i still be able to solve this @abhishek97

@sourabh1031
Copy link

i removed the @ember/jquery package from package.json file and did yarn install but no error came

@abhishek97
Copy link
Contributor Author

You must run the project. I don't know ember, you can start now https://guides.emberjs.com/release/

@farhan787
Copy link

@abhishek97 I ran the project before submitting the PR, it was working fine. Could you please tell me what's going wrong with this ?

@sourabh1031
Copy link

sourabh1031 commented May 28, 2019

@farhan787 before sending pr you must atleast inform that you are working on the use . @abhishek97 i think sending pr in this way is not good because if one will inform that he is working on the issue then other people can try different issues in the meantime

@farhan787
Copy link

farhan787 commented May 28, 2019

@sourabh1031 I think multiple people can try to fix the same issue, as I also don't know Ember. I'm new to it because I worked with React.js. So, there are less chances that everybody will be able to fix it and it's competitive where it matters who solved it first. Other people have also submitted PRs on issues on which I've already submitted but because mine was first and correct so my PR was merged.

@sourabh1031
Copy link

@farhan787 okay i agree with you but i was just saying that writing in the issue description is also good. By the way no problem ,we all can try so go with it

@farhan787
Copy link

@abhishek97 please review it :-)

@farhan787
Copy link

@abhishek97 please review this one and I hope it's the way you wanted it to be :-)

@chtushar
Copy link

@abhishek97 I want to work on this issue please assign. : )

@abhishek97
Copy link
Contributor Author

@chtushar yes, go ahead. We don't "assign" issues here.

@chtushar
Copy link

Okay Thanks : ). On which branch should I send the pull request?

@nitesh585
Copy link

@abhishek97 Can I work on this issue?

@chtushar
Copy link

@abhishek97 I'm getting an Authorization error after setting up and starting the repo.
Screenshot from 2020-05-13 23-47-07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment