From a88980455d52d25d75db4a70a66d3c501313d880 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Tue, 14 Jan 2025 18:25:10 -0800 Subject: [PATCH 1/2] allow brake hold --- selfdrive/selfdrived/events.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/selfdrive/selfdrived/events.py b/selfdrive/selfdrived/events.py index cdc23e53c93d9e..41f08007d625d3 100755 --- a/selfdrive/selfdrived/events.py +++ b/selfdrive/selfdrived/events.py @@ -634,8 +634,11 @@ def personality_changed_alert(CP: car.CarParams, CS: car.CarState, sm: messaging }, EventName.brakeHold: { - ET.USER_DISABLE: EngagementAlert(AudibleAlert.disengage), - ET.NO_ENTRY: NoEntryAlert("Brake Hold Active"), + ET.WARNING: Alert( + "Press Resume to Exit Brake Hold", + "", + AlertStatus.userPrompt, AlertSize.small, + Priority.LOW, VisualAlert.none, AudibleAlert.none, .2), }, EventName.parkBrake: { From 21c49a297ae055801e27db78b413de3a9806ebfa Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Thu, 16 Jan 2025 14:16:33 -0800 Subject: [PATCH 2/2] rev --- selfdrive/car/car_specific.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/selfdrive/car/car_specific.py b/selfdrive/car/car_specific.py index cd2d66228c2a67..144f9f073b82dc 100644 --- a/selfdrive/car/car_specific.py +++ b/selfdrive/car/car_specific.py @@ -191,7 +191,7 @@ def create_common_events(self, CS: structs.CarState, CS_prev: car.CarState, extr events.add(EventName.speedTooHigh) if CS.cruiseState.nonAdaptive: events.add(EventName.wrongCruiseMode) - if CS.brakeHoldActive and self.CP.openpilotLongitudinalControl and self.CP.carName != 'toyota': + if CS.brakeHoldActive and self.CP.openpilotLongitudinalControl: events.add(EventName.brakeHold) if CS.parkingBrake: events.add(EventName.parkBrake)