You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One major issue blocking our release is the number of commits in the same PR, some not rebased.
Looking at the current CONTRIBUTING.md, I think it's not direct about number of commits in a pull request.
This issue is a follow-up so we remember to update it as soon as we can. IMHO, we must not simply say "squash everything into a single commit", but we must ask contributors to only not squash when it makes sense, but we can discuss that and see what others think about it too 👍
The text was updated successfully, but these errors were encountered:
One major issue blocking our release is the number of commits in the same PR, some not rebased.
Looking at the current
CONTRIBUTING.md
, I think it's not direct about number of commits in a pull request.This issue is a follow-up so we remember to update it as soon as we can. IMHO, we must not simply say "squash everything into a single commit", but we must ask contributors to only not squash when it makes sense, but we can discuss that and see what others think about it too 👍
The text was updated successfully, but these errors were encountered: