Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our Contributing guide regarding squashing commits #391

Open
kinow opened this issue May 2, 2023 · 0 comments
Open

Improve our Contributing guide regarding squashing commits #391

kinow opened this issue May 2, 2023 · 0 comments

Comments

@kinow
Copy link
Member

kinow commented May 2, 2023

One major issue blocking our release is the number of commits in the same PR, some not rebased.

Looking at the current CONTRIBUTING.md, I think it's not direct about number of commits in a pull request.

This issue is a follow-up so we remember to update it as soon as we can. IMHO, we must not simply say "squash everything into a single commit", but we must ask contributors to only not squash when it makes sense, but we can discuss that and see what others think about it too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant