Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only checking first variable? #6

Open
skmbr opened this issue Mar 11, 2015 · 4 comments
Open

Only checking first variable? #6

skmbr opened this issue Mar 11, 2015 · 4 comments

Comments

@skmbr
Copy link

skmbr commented Mar 11, 2015

Hi There,

I am currently experimenting with VSF on a development server and am finding that it only catches malicious content if it was put in the first field of a form.

Something like this for example:

<script>alert(1);</script>

Causes a 403 to be returned if put in the very first element of any form that I have tested. If I put that in any other field, VSF ignores it.

Is anyone else seeing similar behaviour or have I just set something up wrong? Currently I have a completely out-of-the-box config and just followed the install instructions from here. No other changes have been made.

Any help of advice would be greatly appreciated! Thanks!

@skmbr
Copy link
Author

skmbr commented Mar 11, 2015

Further to this, I have just discovered that this only occurs on forms that are multipart/form-data encoded.

@fgsch
Copy link
Collaborator

fgsch commented Jul 28, 2015

Long due update..

We had a discussion with @comotion today about this among other things.

Handling of form-data and multiple elements will be implemented in the vsf vmod.
Potential syntax:

  • Iterating directly:
if (vsf.each(data, "..")) {
 ...
}
  • Iterating via the form object:
form = new vsf.form(2048B);
...
if (form.each(data, "..")) {
  ...
}

Maybe others.

There are some outstanding details to close before deciding.

@hellracer
Copy link

Hi fgsch,

Good day, any progress on this you guys made so far?

@fgsch
Copy link
Collaborator

fgsch commented Oct 21, 2015

@hellracer Not really. I've been quite busy.

That said, the latest code won't try to parse the form so you can check the raw data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants