Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite hack/mock-unittest-data/gomod.sh in Python #776

Open
eskultety opened this issue Jan 3, 2025 · 1 comment
Open

Rewrite hack/mock-unittest-data/gomod.sh in Python #776

eskultety opened this issue Jan 3, 2025 · 1 comment
Labels
my first issue Good for newcomers

Comments

@eskultety
Copy link
Member

Having a structured logic instead of an inline subshell heredoc would enhance readability of the helper script significantly and the potentially larger number of lines as a result of such a rewrite is an acceptable trade-off.

@eskultety eskultety added the my first issue Good for newcomers label Jan 3, 2025
@brunoapimentel
Copy link
Contributor

I have always wondered if automatically genering mock data for a unit test is worth the effort. I'd be happier if we could further break down the massive _resolve_gomod function and rely on a few simpler unit tests, and completely drop down the mock generation part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
my first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants