Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] RectangleROI & EllipseROI ignoring storePointData configuration #1709

Open
julianlinaress opened this issue Dec 13, 2024 · 0 comments · May be fixed by #1733
Open

[Bug] RectangleROI & EllipseROI ignoring storePointData configuration #1709

julianlinaress opened this issue Dec 13, 2024 · 0 comments · May be fixed by #1733
Assignees

Comments

@julianlinaress
Copy link

julianlinaress commented Dec 13, 2024

Describe the Bug

pointsInShape are being stored (or provided in CORNERSTONE_TOOLS_ANNOTATION_COMPLETED event, (event.detail.anntotation ) with storePointData set to false

Steps to Reproduce

  1. After initializing cs, tools and a toolGroup:
toolGroup.setToolActive('RectangleROI' { bindings: [{ mouseButton: 1 }] });
toolGroup.setToolConfiguration('RectangleROI', { storePointData: false }); // optional, it's set to false by default
console.log(toolGroup.getToolConfiguration('RectangleROI'));
  1. Draw the annotation on a StackViewport and log it (or store it anywhere you can see it)
Cornerstone3D.eventTarget.addEventListener("CORNERSTONE_TOOLS_ANNOTATION_COMPLETED", (e) => {
    console.log(e.detail.annotation);
}
  1. You will be able to see "pointsInShape" atribute in data.cachedStats.imageId...{}

The current behavior

pointsInShape are being stored (or provided in CORNERSTONE_TOOLS_ANNOTATION_COMPLETED event, (event.detail.anntotation ) with storePointData set to false

The expected behavior

Getting the annotation object without points data when storePointData is set to false

OS

Windows 11

Node version

22.11.0

Browser

Chrome, Firefox

daker added a commit to daker/cornerstone3D that referenced this issue Dec 28, 2024
@daker daker linked a pull request Dec 28, 2024 that will close this issue
2 tasks
@linear linear bot assigned sedghi Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants