Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Calendar Block in RTL language should change direction of drawing days from right to left and start day of week should be changed to. #1461

Open
1 task done
Githubuser338 opened this issue Sep 27, 2023 · 7 comments
Labels
bug Something isn't working frontend Frontend code changes (Javascript, Typescript, Vue.js) no-issue-activity
Milestone

Comments

@Githubuser338
Copy link

Githubuser338 commented Sep 27, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Version of Corteza

2023.3.6

Current Behavior

When I use My Calendar in CRM application, when language is 'fa', Calendar type is correctly jalali but direction of calendar block and start day of week is incorrect.
inactive days in calendar is still painted according to gregorian calendar.

Expected Behavior

Direction of days should be from right to left , and start day of week should be 'شنبه' or 'saturday'.
inactive days in calendar in month view should be painted according to jalali calendar.

Steps To Reproduce

  1. change 'preferred language' in user profile.
  2. select 6 dot to return to main page.
  3. select CRM application
  4. go to home page

Environment and versions

No response

Anything else?

I RTL languages , Calendar type in calendar block (or Date picker component) should be changed according to selected language and country culture.

@Fajfa
Copy link
Member

Fajfa commented Oct 19, 2023

Thanks for reporting it

@Fajfa Fajfa added bug Something isn't working frontend Frontend code changes (Javascript, Typescript, Vue.js) labels Oct 19, 2023
@Fajfa Fajfa added this to the 2023.9.1 milestone Oct 19, 2023
@Fajfa Fajfa modified the milestones: 2023.9.1, 2023.9.2 Nov 27, 2023
@katrinDY katrinDY self-assigned this Dec 8, 2023
@katrinDY katrinDY modified the milestones: 2023.9.2, 2023.9.3 Dec 8, 2023
@Githubuser338
Copy link
Author

it seems RTL is not in top of your periority list, because other module like report does not support rtl too. and of course controls like datepicker, calendar and kanban board should support other calendars too. it is a lot of work to do

@Fajfa Fajfa modified the milestones: 2023.9.3, 2023.9.4 Jan 16, 2024
@Fajfa Fajfa modified the milestones: 2023.9.4, 2024.3.x Feb 1, 2024
@katrinDY
Copy link
Contributor

katrinDY commented Feb 1, 2024

Putting on hold for now since two issues have to be resolved:

  • broken classes for default views
  • broken views on view change

Copy link

github-actions bot commented Apr 2, 2024

Stale issue message

Copy link

Stale issue message

@katrinDY
Copy link
Contributor

Branch: 2023.9.x-feature-update-full-calendar-to-fix-persian-cal-issues

I managed to adjust the text direction according to the currently selected language by updating the cal library to the then latest verison but a lot of styles are broken for the different calendar views (day, month, week, agenda). What I would do is wait for a version where the styles aren't so broken

Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Frontend code changes (Javascript, Typescript, Vue.js) no-issue-activity
Projects
None yet
Development

No branches or pull requests

3 participants