Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is there body,html{height:auto} in the CSS of the bar ? #705

Open
ptbrowne opened this issue Oct 2, 2020 · 0 comments
Open

Why is there body,html{height:auto} in the CSS of the bar ? #705

ptbrowne opened this issue Oct 2, 2020 · 0 comments

Comments

@ptbrowne
Copy link
Contributor

ptbrowne commented Oct 2, 2020

We've had a bug on the home where the body,html{display:block;height:auto} from
http://pbrowne.mycozy.cloud/assets/css/cozy-bar.aa10decc4f.min.css
is overriding the html{height: 100%} used by the home.

This causes the background to be bigger than expected since in most cases, the
page will be taller than the viewport.

ptbrowne added a commit to cozy/cozy-home that referenced this issue Oct 2, 2020
The bar is injecting html,body{height:auto} which is messing with
the height set by the home CSS. We can see this bug due to a
change of order in the CSS. Normally the bar should not inject
this height:auto (see cozy/cozy-bar#705)
but at the moment to solve the problem, !important is needed
ptbrowne added a commit to cozy/cozy-home that referenced this issue Oct 2, 2020
The bar is injecting html,body{height:auto} which is messing with
the height set by the home CSS. We can see this bug due to a
change of order in the CSS. Normally the bar should not inject
this height:auto (see cozy/cozy-bar#705)
but at the moment to solve the problem, !important is needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant