Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a minimal test for slicing the simplest wav file #62

Open
5 tasks
audreyfeldroy opened this issue Oct 6, 2023 · 3 comments
Open
5 tasks

Write a minimal test for slicing the simplest wav file #62

audreyfeldroy opened this issue Oct 6, 2023 · 3 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest-accepted Issue or PR is approved for anyone who wants it to count toward Hacktoberfest help wanted Extra attention is needed

Comments

@audreyfeldroy
Copy link
Member

  • Familiarize yourself with the very basics of pytest
  • Create the file tests/test_slicer.py
  • Define a test in test_slicer.py called test_audio_slicing
  • In your test, create a simple wav file per https://stackoverflow.com/a/57192182/271697
  • In your test, call audio_slicing() with your wav file and verify that the slices are created

If you have more experience with pytest and want to use fixtures, etc. you can, or you can just write the simplest possible test per above and we can iterate later.

@audreyfeldroy audreyfeldroy added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest-accepted Issue or PR is approved for anyone who wants it to count toward Hacktoberfest labels Oct 6, 2023
@RalphHuber
Copy link
Collaborator

mind if I pick this up?

@audreyfeldroy
Copy link
Member Author

Thanks for offering to take this one @RalphHuber. Just a friendly heads up that the API may end up changing... I woke up in the middle of the night realizing that we probably ought to look into using existing Python FFMpeg to reduce our lines of code, which @heymanpreet is just starting to look into.

@RalphHuber
Copy link
Collaborator

No worries @audreyfeldroy, I'll push the PR soon. No worries if it's not useful in the end, was only a quick change last night.

What's the difference in using pydub vs FFMpeg? I'm not very clued up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest-accepted Issue or PR is approved for anyone who wants it to count toward Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants