-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[False Negative]: Not show the correct report on unused imports #2535
Comments
Can you provide a link to a repo that builds so we can reproduce this? The code snippet is incomplete |
in Сontract1, I used two imports from Сontract2 and interface IMyImport. Also in Сontract2, I used the interface, but in Сontract1 it does not show an unused Сontract2, when i used command.
the terminal Outputs
|
@0xalpharush please take a look |
I haven't had a chance to look at this, but the detector was disabled in the latest release bc it was slow and flagging imports that were used |
I had a similar problem and realized I wasn't in my project, I was in Slither, I cd'd into my puppy raffle file and it worked. Not sure if this helps |
What bug did Slither miss and which detector did you anticipate would catch it?
I have unused imports and it doesn't detect them.
slither . --skip-assembly --detect "unused-import"
Frequency
Very Frequently
Code example to reproduce the issue:
pragma solidity ^0.8.26;
import {FixedPointMathLib} from "solady/utils/FixedPointMathLib.sol";
import {IPoolManager} from "v4-core/interfaces/IPoolManager.sol";
import {Hooks} from "v4-core/libraries/Hooks.sol";
import {LPFeeLibrary} from "v4-core/libraries/LPFeeLibrary.sol";
import {StateLibrary} from "v4-core/libraries/StateLibrary.sol";
import {BeforeSwapDelta, BeforeSwapDeltaLibrary} from "v4-core/types/BeforeSwapDelta.sol";
import {Currency, CurrencyLibrary} from "v4-core/types/Currency.sol";
import {PoolId, PoolIdLibrary} from "v4-core/types/PoolId.sol";
import {PoolKey} from "v4-core/types/PoolKey.sol";
import {BaseHook} from "v4-periphery/BaseHook.sol";
import {MyImport} from "./MyImport.sol"; <---- this unused import
Version:
slither --version
0.10.3
Relevant log output:
The text was updated successfully, but these errors were encountered: