Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: add support for cleanup before deleting dag. #694

Open
kriyanshii opened this issue Oct 31, 2024 · 2 comments
Open

template: add support for cleanup before deleting dag. #694

kriyanshii opened this issue Oct 31, 2024 · 2 comments
Labels
enhancement New feature to be implemented
Milestone

Comments

@kriyanshii
Copy link
Contributor

kriyanshii commented Oct 31, 2024

introducing a new field in dag cleanup:. where you can mention any script(path to the script). So it will run that script while deleting the dag. It can be used to clean up intermediate files made while the dag ran.

steps:
  - name: "1"
    command: "true"
cleanup: "/path/to/script.sh"

@yohamta yohamta changed the title add support for cleanup before deleting dag. template: add support for cleanup before deleting dag. Dec 29, 2024
@yohamta yohamta added this to the v1.17.0 milestone Jan 10, 2025
@yohamta yohamta added the enhancement New feature to be implemented label Jan 10, 2025
@kriyanshii
Copy link
Contributor Author

i would like to work on this.

@yohamta
Copy link
Collaborator

yohamta commented Jan 11, 2025

Thanks a lot! How would you like to implement it? I'd be grateful if you could share planning changes and design about this functionality. I'm still a bit unsure when the script should be called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature to be implemented
Projects
None yet
Development

No branches or pull requests

2 participants