fix: stylex example to use new vite plugin #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tylersayshi
commented
Dec 28, 2024
|
There seems an issue with first load
after reload
Can you reproduce it on your end? @tylersayshi |
|
@dai-shi i see the same. I might not have time to debug tonight but could look closer soon. This is specific to dev though. The issue is not present once we run waku build and waku start |
|
No hurry. Yeah, dev only, but that's the issue. I think that's why we changed the plugin to |
This was referenced Dec 29, 2024
dai-shi
pushed a commit
that referenced
this pull request
Dec 29, 2024
for #1102 This reverts #1105 and reopens #750. Co-authored-by: Tyler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #750