From 2663ae103d2d370f8d8fdbaf65906f6f66fec442 Mon Sep 17 00:00:00 2001 From: Roi-Arthur <48017311+Roi-Arthur@users.noreply.github.com> Date: Wed, 6 Sep 2023 14:45:48 +0100 Subject: [PATCH 01/58] Add liquid to assign uses_comma_decimals on mobile (#2980) Fixes #2981 --- snippets/facets.liquid | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/snippets/facets.liquid b/snippets/facets.liquid index 44ad719f915..219bc09ad9a 100644 --- a/snippets/facets.liquid +++ b/snippets/facets.liquid @@ -304,7 +304,7 @@ {% when 'price_range' %} {% liquid - assign currencies_using_comma_decimals = 'ANG,ARS,BRL,BYN,BYR,CLF,CLP,COP,CRC,CZK,DKK,EUR,HRK,HUF,IDR,ISK,MZN,NOK,PLN,RON,RUB,SEK,TRY,UYU,VES,VND' | split: ',' + assign currencies_using_comma_decimals = 'ANG,ARS,BRL,BYN,BYR,CLF,CLP,COP,CRC,CZK,DKK,EUR,HRK,HUF,IDR,ISK,MZN,NOK,PLN,RON,RUB,SEK,UYU,VES,VND' | split: ',' assign uses_comma_decimals = false if currencies_using_comma_decimals contains cart.currency.iso_code assign uses_comma_decimals = true @@ -749,6 +749,13 @@ {% when 'price_range' %} + {% liquid + assign currencies_using_comma_decimals = 'ANG,ARS,BRL,BYN,BYR,CLF,CLP,COP,CRC,CZK,DKK,EUR,HRK,HUF,IDR,ISK,MZN,NOK,PLN,RON,RUB,SEK,UYU,VES,VND' | split: ',' + assign uses_comma_decimals = false + if currencies_using_comma_decimals contains cart.currency.iso_code + assign uses_comma_decimals = true + endif + %}
Date: Mon, 18 Sep 2023 11:38:30 -0400 Subject: [PATCH 02/58] Update 1 translation file (#2997) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> --- locales/da.schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/locales/da.schema.json b/locales/da.schema.json index 75d9417f1c3..3132cb08a13 100644 --- a/locales/da.schema.json +++ b/locales/da.schema.json @@ -900,7 +900,7 @@ }, "header__9": { "content": "Følg på Shop", - "info": "Hvis du vil give kunder mulighed for at følge din butik i Shop-appen via din butiksfacade, skal du have aktiveret Shop Pay. [Få mere at vide](https://help.shopify.com/manual/online-store/themes/customizing-themes/follow-on-shop)" + "info": "Hvis du vil give kunder mulighed for at følge din butik i Shop-appen via dit butikslayout, skal du have aktiveret Shop Pay. [Få mere at vide](https://help.shopify.com/manual/online-store/themes/customizing-themes/follow-on-shop)" }, "enable_follow_on_shop": { "label": "Aktivér Følg på Shop" From d8a2422031e5ce7ea5265486a3e39f302203739d Mon Sep 17 00:00:00 2001 From: "translation-platform[bot]" <34770790+translation-platform[bot]@users.noreply.github.com> Date: Tue, 19 Sep 2023 12:30:32 -0400 Subject: [PATCH 03/58] Update 1 translation file (#3001) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> --- locales/zh-CN.schema.json | 66 +++++++++++++++++++-------------------- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/locales/zh-CN.schema.json b/locales/zh-CN.schema.json index 78a321ef1e5..7b63ff0eacd 100644 --- a/locales/zh-CN.schema.json +++ b/locales/zh-CN.schema.json @@ -222,7 +222,7 @@ }, "variant_pills": { "name": "多属性椭圆形框", - "paragraph": "多属性椭圆形框是显示产品多属性的一种方式。[了解详细信息](https://help.shopify.com/en/manual/online-store/themes/theme-structure/page-types#variant-picker-block)" + "paragraph": "多属性椭圆形框是显示产品多属性的一种方式。[详细了解](https://help.shopify.com/en/manual/online-store/themes/theme-structure/page-types#variant-picker-block)" }, "inputs": { "name": "输入" @@ -585,7 +585,7 @@ }, "description": { "label": "视频替代文本", - "info": "为使用屏幕阅读器的客户描述视频。[了解详细信息](https://help.shopify.com/manual/online-store/themes/theme-structure/theme-features#video-block)" + "info": "为使用屏幕阅读器的客户描述视频。[详细了解](https://help.shopify.com/manual/online-store/themes/theme-structure/theme-features#video-block)" } }, "name": "视频" @@ -612,7 +612,7 @@ "options__3": { "label": "方形" }, - "info": "通过编辑产品集合来添加图片。[了解详细信息](https://help.shopify.com/manual/products/collections)" + "info": "通过编辑产品集合来添加图片。[详细了解](https://help.shopify.com/manual/products/collections)" }, "swipe_on_mobile": { "label": "在移动设备上启用刷卡功能" @@ -661,7 +661,7 @@ "settings": { "custom_liquid": { "label": "Liquid 代码", - "info": "添加应用代码片段或其他代码以创建高级自定义。[了解详细信息](https://shopify.dev/docs/api/liquid)" + "info": "添加应用代码片段或其他代码以创建高级自定义。[详细了解](https://shopify.dev/docs/api/liquid)" } }, "presets": { @@ -685,7 +685,7 @@ }, "show_image": { "label": "显示配图", - "info": "若要获得最佳效果,请使用纵横比为 3:2 的图片。[了解详细信息](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)" + "info": "若要获得最佳效果,请使用纵横比为 3:2 的图片。[详细了解](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)" }, "show_date": { "label": "显示日期" @@ -739,7 +739,7 @@ }, "show_rating": { "label": "显示产品评分", - "info": "若要显示评分,请添加产品评分应用。[了解详细信息](https://help.shopify.com/manual/online-store/themes/theme-structure/theme-features#featured-collection-show-product-rating)" + "info": "若要显示评分,请添加产品评分应用。[详细了解](https://help.shopify.com/manual/online-store/themes/theme-structure/theme-features#featured-collection-show-product-rating)" }, "enable_quick_buy": { "label": "启用快速添加按钮", @@ -854,7 +854,7 @@ "label": "标题" }, "header__1": { - "info": "订阅者已自动添加到您的“已接受营销”客户列表。[了解详细信息](https://help.shopify.com/manual/customers/manage-customers)", + "info": "订阅者已自动添加到您的“已接受营销”客户列表。[详细了解](https://help.shopify.com/manual/customers/manage-customers)", "content": "电子邮件注册信息" }, "header__2": { @@ -900,7 +900,7 @@ }, "header__9": { "content": "在 Shop 中关注", - "info": "若要使客户能够通过您的店面在 Shop 应用中关注您的商店,则必须启用 Shop Pay。[了解详细信息](https://help.shopify.com/manual/online-store/themes/customizing-themes/follow-on-shop)" + "info": "若要使客户能够通过您的店面在 Shop 应用中关注您的商店,则必须启用 Shop Pay。[详细了解](https://help.shopify.com/manual/online-store/themes/customizing-themes/follow-on-shop)" }, "enable_follow_on_shop": { "label": "启用在 Shop 中关注" @@ -1035,7 +1035,7 @@ "options__3": { "label": "中" }, - "info": "若要获得最佳效果,请使用纵横比为 3:2 的图片。[了解详细信息](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)", + "info": "若要获得最佳效果,请使用纵横比为 3:2 的图片。[详细了解](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)", "options__4": { "label": "大" } @@ -1338,7 +1338,7 @@ "options__3": { "label": "中" }, - "info": "若要获得最佳效果,请使用纵横比为 16:9 的图片。[了解详细信息](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)", + "info": "若要获得最佳效果,请使用纵横比为 16:9 的图片。[详细了解](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)", "options__4": { "label": "大" } @@ -1386,7 +1386,7 @@ "label": "显示配图" }, "paragraph": { - "content": "通过编辑博客文章来更改摘录。[了解详细信息](https://help.shopify.com/manual/online-store/blogs/writing-blogs#display-an-excerpt-from-a-blog-post)" + "content": "通过编辑博客文章来更改摘录。[详细了解](https://help.shopify.com/manual/online-store/blogs/writing-blogs#display-an-excerpt-from-a-blog-post)" }, "show_date": { "label": "显示日期" @@ -1418,7 +1418,7 @@ "options__4": { "label": "大" }, - "info": "若要获得最佳效果,请使用纵横比为 3:2 的图片。[了解详细信息](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)" + "info": "若要获得最佳效果,请使用纵横比为 3:2 的图片。[详细了解](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)" } } }, @@ -1440,14 +1440,14 @@ "name": "产品系列横幅", "settings": { "paragraph": { - "content": "通过编辑产品系列来添加描述或图片。[了解详细信息](https://help.shopify.com/manual/products/collections/collection-layout)" + "content": "通过编辑产品系列来添加描述或图片。[详细了解](https://help.shopify.com/manual/products/collections/collection-layout)" }, "show_collection_description": { "label": "显示产品系列描述" }, "show_collection_image": { "label": "显示产品系列图片", - "info": "若要获得最佳效果,请使用纵横比为 16:9 的图片。[了解详细信息](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)" + "info": "若要获得最佳效果,请使用纵横比为 16:9 的图片。[详细了解](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)" } } }, @@ -1480,11 +1480,11 @@ }, "enable_tags": { "label": "启用筛选", - "info": "使用 Search & Discovery 应用自定义筛选条件。[了解详细信息](https://help.shopify.com/manual/online-store/search-and-discovery/filters)" + "info": "使用 Search & Discovery 应用自定义筛选条件。[详细了解](https://help.shopify.com/manual/online-store/search-and-discovery/filters)" }, "enable_filtering": { "label": "启用筛选", - "info": "使用 Search & Discovery 应用自定义筛选条件。[了解详细信息](https://help.shopify.com/manual/online-store/search-and-discovery/filters)" + "info": "使用 Search & Discovery 应用自定义筛选条件。[详细了解](https://help.shopify.com/manual/online-store/search-and-discovery/filters)" }, "enable_sorting": { "label": "启用排序" @@ -1494,7 +1494,7 @@ }, "show_rating": { "label": "显示产品评分", - "info": "若要显示评分,请添加产品评分应用。[了解详细信息](https://help.shopify.com/manual/online-store/themes/theme-structure/page-types#product-grid-section-settings)" + "info": "若要显示评分,请添加产品评分应用。[详细了解](https://help.shopify.com/manual/online-store/themes/theme-structure/page-types#product-grid-section-settings)" }, "enable_quick_buy": { "label": "启用快速添加按钮", @@ -1568,7 +1568,7 @@ "options__3": { "label": "方形" }, - "info": "通过编辑产品集合来添加图片。[了解详细信息](https://help.shopify.com/manual/products/collections)" + "info": "通过编辑产品集合来添加图片。[详细了解](https://help.shopify.com/manual/products/collections)" }, "columns_desktop": { "label": "台式设备上的列数" @@ -1649,7 +1649,7 @@ }, "show_gift_card_recipient": { "label": "显示礼品卡的收件人信息表单", - "info": "允许客户在预定日期发送礼品卡并附加私人消息。[了解详细信息](https://help.shopify.com/manual/online-store/themes/customizing-themes/add-gift-card-recipient-fields)" + "info": "允许客户在预定日期发送礼品卡并附加私人消息。[详细了解](https://help.shopify.com/manual/online-store/themes/customizing-themes/add-gift-card-recipient-fields)" } }, "name": "Buy Button" @@ -1848,7 +1848,7 @@ "name": "产品评分", "settings": { "paragraph": { - "content": "若要显示评分,请添加产品评分应用。[了解详细信息](https://help.shopify.com/manual/online-store/themes/theme-structure/page-types#product-rating-block)" + "content": "若要显示评分,请添加产品评分应用。[详细了解](https://help.shopify.com/manual/online-store/themes/theme-structure/page-types#product-rating-block)" } } }, @@ -1856,7 +1856,7 @@ "name": "互补产品", "settings": { "paragraph": { - "content": "若要选择互补产品,请添加 Search & Discovery 应用。[了解详细信息](https://help.shopify.com/manual/online-store/search-and-discovery/product-recommendations)" + "content": "若要选择互补产品,请添加 Search & Discovery 应用。[详细了解](https://help.shopify.com/manual/online-store/search-and-discovery/product-recommendations)" }, "heading": { "label": "标题" @@ -2113,7 +2113,7 @@ }, "show_rating": { "label": "显示产品评分", - "info": "若要显示评分,请添加产品评分应用。[了解详细信息](https://help.shopify.com/manual/online-store/themes/theme-structure/page-types#search-results-section-settings)" + "info": "若要显示评分,请添加产品评分应用。[详细了解](https://help.shopify.com/manual/online-store/themes/theme-structure/page-types#search-results-section-settings)" }, "columns_desktop": { "label": "桌面上的列数" @@ -2241,7 +2241,7 @@ "label": "使分区展示全宽" }, "paragraph": { - "content": "每次电子邮件订阅均会创建一个客户账户。[了解详细信息](https://help.shopify.com/manual/customers)" + "content": "每次电子邮件订阅均会创建一个客户账户。[详细了解](https://help.shopify.com/manual/customers)" } }, "blocks": { @@ -2414,7 +2414,7 @@ }, "description": { "label": "视频替代文本", - "info": "为使用屏幕阅读器的客户描述视频。[了解详细信息](https://help.shopify.com/manual/online-store/themes/theme-structure/theme-features#video)" + "info": "为使用屏幕阅读器的客户描述视频。[详细了解](https://help.shopify.com/manual/online-store/themes/theme-structure/theme-features#video)" }, "image_padding": { "label": "添加图片填充", @@ -2497,7 +2497,7 @@ "settings": { "show_dynamic_checkout": { "label": "显示动态结账按钮", - "info": "通过使用您商店中提供的付款方式,客户会看到他们的首选付款方式,例如 PayPal 或 Apple Pay。[了解详细信息](https://help.shopify.com/manual/using-themes/change-the-layout/dynamic-checkout)" + "info": "通过使用您商店中提供的付款方式,客户会看到他们的首选付款方式,例如 PayPal 或 Apple Pay。[详细了解](https://help.shopify.com/manual/using-themes/change-the-layout/dynamic-checkout)" } } }, @@ -2508,10 +2508,10 @@ "name": "分享", "settings": { "featured_image_info": { - "content": "如果您在社交媒体帖子中包含链接,该页面的配图将作为预览图片显示。[了解详细信息](https://help.shopify.com/manual/online-store/images/showing-social-media-thumbnail-images)" + "content": "如果您在社交媒体帖子中包含链接,该页面的配图将作为预览图片显示。[详细了解](https://help.shopify.com/manual/online-store/images/showing-social-media-thumbnail-images)" }, "title_info": { - "content": "预览图片中包含商店标题和描述。[了解详细信息](https://help.shopify.com/manual/promoting-marketing/seo/adding-keywords#set-a-title-and-description-for-your-online-store)" + "content": "预览图片中包含商店标题和描述。[详细了解](https://help.shopify.com/manual/promoting-marketing/seo/adding-keywords#set-a-title-and-description-for-your-online-store)" }, "text": { "label": "文本" @@ -2522,7 +2522,7 @@ "name": "产品评分", "settings": { "paragraph": { - "content": "若要显示评分,请添加产品评分应用。[了解详细信息](https://help.shopify.com/manual/online-store/themes/theme-structure/theme-features#featured-product-rating)" + "content": "若要显示评分,请添加产品评分应用。[详细了解](https://help.shopify.com/manual/online-store/themes/theme-structure/theme-features#featured-product-rating)" } } }, @@ -2580,7 +2580,7 @@ "name": "电子邮件注册横幅", "settings": { "paragraph": { - "content": "每次电子邮件订阅均会创建一个客户账户。[了解详细信息](https://help.shopify.com/manual/customers)" + "content": "每次电子邮件订阅均会创建一个客户账户。[详细了解](https://help.shopify.com/manual/customers)" }, "image": { "label": "背景图片" @@ -2596,7 +2596,7 @@ }, "show_text_below": { "label": "在移动设备上的图片下方显示内容。", - "info": "若要获得最佳效果,请使用纵横比为 16:9 的图片。[了解详细信息](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)" + "info": "若要获得最佳效果,请使用纵横比为 16:9 的图片。[详细了解](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)" }, "image_height": { "label": "横幅高度", @@ -2612,7 +2612,7 @@ "options__4": { "label": "大" }, - "info": "若要获得最佳效果,请使用纵横比为 16:9 的图片。[了解详细信息](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)" + "info": "若要获得最佳效果,请使用纵横比为 16:9 的图片。[详细了解](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)" }, "desktop_content_position": { "options__4": { @@ -3116,7 +3116,7 @@ "label": "台式设备上的列数" }, "paragraph__1": { - "content": "动态推荐使用订单和产品信息来随着时间而变化和改进。[了解详细信息](https://help.shopify.com/themes/development/recommended-products)" + "content": "动态推荐使用订单和产品信息来随着时间而变化和改进。[详细了解](https://help.shopify.com/themes/development/recommended-products)" }, "header__2": { "content": "产品卡" @@ -3141,7 +3141,7 @@ }, "show_rating": { "label": "显示产品评分", - "info": "若要显示评分,请添加产品评分应用。[了解详细信息](https://help.shopify.com/manual/online-store/themes/theme-structure/page-types#product-recommendations-section-settings)" + "info": "若要显示评分,请添加产品评分应用。[详细了解](https://help.shopify.com/manual/online-store/themes/theme-structure/page-types#product-recommendations-section-settings)" }, "header_mobile": { "content": "移动设备布局" From 92d3440dd032a592da05e2af017c02124a3bfe2e Mon Sep 17 00:00:00 2001 From: Ludo Date: Wed, 20 Sep 2023 10:36:35 -0400 Subject: [PATCH 04/58] [Image_tag] Update to remove lazy loading and let it automatically decide the best loading strategy (#3002) * remove lazy loading where necessary to better performance * add fetch priority --- sections/collage.liquid | 6 ++---- sections/collapsible-content.liquid | 1 - sections/image-banner.liquid | 12 ++++++++---- sections/image-with-text.liquid | 10 ++++++++-- sections/multicolumn.liquid | 1 - sections/multirow.liquid | 2 +- sections/slideshow.liquid | 22 +++++++++++++++++----- sections/video.liquid | 8 ++------ 8 files changed, 38 insertions(+), 24 deletions(-) diff --git a/sections/collage.liquid b/sections/collage.liquid index 39551f05635..19706ab5d84 100644 --- a/sections/collage.liquid +++ b/sections/collage.liquid @@ -68,7 +68,6 @@ block.settings.image | image_url: width: 3200 | image_tag: - loading: 'lazy', sizes: sizes, widths: '50, 75, 100, 150, 200, 300, 400, 500, 750, 1000, 1250, 1500, 1750, 2000, 2250, 2500, 2750, 3000, 3200' }} @@ -82,7 +81,6 @@ block.settings.image | image_url: width: 3200 | image_tag: - loading: 'lazy', sizes: sizes, widths: '50, 75, 100, 150, 200, 300, 400, 500, 750, 1000, 1250, 1500, 1750, 2000, 2250, 2500, 2750, 3000, 3200' }} @@ -141,7 +139,7 @@ {{ block.settings.cover_image | image_url: width: 3000 - | image_tag: loading: 'lazy', sizes: sizes, widths: '550, 720, 990, 1100, 1500, 2200, 3000' + | image_tag: sizes: sizes, widths: '550, 720, 990, 1100, 1500, 2200, 3000' }} {%- else -%} {{ 'hero-apparel-3' | placeholder_svg_tag: 'placeholder-svg placeholder' }} @@ -185,7 +183,7 @@ {{ block.settings.cover_image | image_url: width: 3000 - | image_tag: loading: 'lazy', sizes: sizes, widths: '550, 720, 990, 1100, 1500, 2200, 3000' + | image_tag: sizes: sizes, widths: '550, 720, 990, 1100, 1500, 2200, 3000' }} {%- else -%} {{ 'hero-apparel-3' | placeholder_svg_tag: 'placeholder-svg placeholder' }} diff --git a/sections/collapsible-content.liquid b/sections/collapsible-content.liquid index 6dee94dc51b..9acb813ed6e 100644 --- a/sections/collapsible-content.liquid +++ b/sections/collapsible-content.liquid @@ -62,7 +62,6 @@ section.settings.image | image_url: width: 3200 | image_tag: - loading: 'lazy', sizes: sizes, widths: '50, 75, 100, 150, 200, 300, 400, 500, 750, 1000, 1250, 1500, 1750, 2000, 2250, 2500, 2750, 3000, 3200' }} diff --git a/sections/image-banner.liquid b/sections/image-banner.liquid index ee51b92ba55..2eaad5ef4e0 100644 --- a/sections/image-banner.liquid +++ b/sections/image-banner.liquid @@ -45,6 +45,10 @@ assign half_width = '50vw' assign stacked_sizes = '(min-width: 750px) 50vw, 100vw' endif + assign fetch_priority = 'auto' + if section.index == 1 + assign fetch_priority = 'high' + endif -%}
{%- elsif section.settings.image_2 == blank -%} @@ -102,12 +106,12 @@ section.settings.image_2 | image_url: width: 3840 | image_tag: - loading: 'lazy', width: section.settings.image_2.width, height: image_height_2, class: image_class_2, sizes: sizes, - widths: widths + widths: widths, + fetchpriority: fetch_priority }}
{%- endif -%} diff --git a/sections/image-with-text.liquid b/sections/image-with-text.liquid index 927c0b986c4..359324b2046 100644 --- a/sections/image-with-text.liquid +++ b/sections/image-with-text.liquid @@ -14,7 +14,13 @@ } {%- endstyle -%} -{% assign scheme1 = settings.color_schemes | first %} +{%- liquid + assign scheme1 = settings.color_schemes | first + assign fetch_priority = 'auto' + if section.index == 1 + assign fetch_priority = 'high' + endif +-%}
@@ -42,7 +48,7 @@ {{ section.settings.image | image_url: width: 1500 - | image_tag: loading: 'lazy', sizes: sizes, widths: widths + | image_tag: sizes: sizes, widths: widths, fetchpriority: fetch_priority }} {%- else -%} {{ 'detailed-apparel-1' | placeholder_svg_tag: 'placeholder-svg' }} diff --git a/sections/multicolumn.liquid b/sections/multicolumn.liquid index cc5490dc245..fa21082ed02 100644 --- a/sections/multicolumn.liquid +++ b/sections/multicolumn.liquid @@ -111,7 +111,6 @@ block.settings.image | image_url: width: 3200 | image_tag: - loading: 'lazy', widths: '50, 75, 100, 150, 200, 300, 400, 500, 750, 1000, 1250, 1500, 1750, 2000, 2250, 2500, 2750, 3000, 3200', sizes: sizes, class: 'multicolumn-card__image' diff --git a/sections/multirow.liquid b/sections/multirow.liquid index 9795a3d6231..e600f974e85 100644 --- a/sections/multirow.liquid +++ b/sections/multirow.liquid @@ -65,7 +65,7 @@ {{ block.settings.image | image_url: width: 1500 - | image_tag: loading: 'lazy', sizes: sizes, widths: '165, 360, 535, 750, 1070, 1500' + | image_tag: sizes: sizes, widths: '165, 360, 535, 750, 1070, 1500' }} {%- else -%} {{ 'detailed-apparel-1' | placeholder_svg_tag: 'placeholder-svg' }} diff --git a/sections/slideshow.liquid b/sections/slideshow.liquid index eba91e849b7..a2d048bf428 100644 --- a/sections/slideshow.liquid +++ b/sections/slideshow.liquid @@ -138,12 +138,24 @@ assign sizes = '100vw' assign widths = '375, 550, 750, 1100, 1500, 1780, 2000, 3000, 3840' endif + assign fetch_priority = 'auto' + if section.index == 1 + assign fetch_priority = 'high' + endif -%} - {{ - block.settings.image - | image_url: width: 3840 - | image_tag: loading: 'lazy', height: height, sizes: sizes, widths: widths - }} + {%- if forloop.first %} + {{ + block.settings.image + | image_url: width: 3840 + | image_tag: height: height, sizes: sizes, widths: widths, fetchpriority: fetch_priority + }} + {%- else -%} + {{ + block.settings.image + | image_url: width: 3840 + | image_tag: loading: 'lazy', height: height, sizes: sizes, widths: widths + }} + {%- endif -%} {%- else -%} {%- assign placeholder_slide = forloop.index | modulo: 2 -%} {%- if placeholder_slide == 1 -%} diff --git a/sections/video.liquid b/sections/video.liquid index dfe5ebc7761..624918ea904 100644 --- a/sections/video.liquid +++ b/sections/video.liquid @@ -67,11 +67,7 @@ {{ poster | image_url: width: 3840 - | image_tag: - loading: 'lazy', - sizes: sizes, - widths: '375, 750, 1100, 1500, 1780, 2000, 3000, 3840', - alt: alt + | image_tag: sizes: sizes, widths: '375, 750, 1100, 1500, 1780, 2000, 3000, 3840', alt: alt }} {%- else -%} {{ 'hero-apparel-3' | placeholder_svg_tag: 'placeholder-svg placeholder' }} @@ -102,7 +98,7 @@ {{ poster | image_url: width: 3840 - | image_tag: loading: 'lazy', sizes: sizes, widths: '375, 750, 1100, 1500, 1780, 2000, 3000, 3840', alt: alt + | image_tag: sizes: sizes, widths: '375, 750, 1100, 1500, 1780, 2000, 3000, 3840', alt: alt }} {%- else -%} {{ 'hero-apparel-3' | placeholder_svg_tag: 'placeholder-svg placeholder' }} From 4dacca1f43a22d57e20c24ac66696cf6de56291f Mon Sep 17 00:00:00 2001 From: Patrick Racicot Date: Wed, 20 Sep 2023 15:27:46 -0400 Subject: [PATCH 05/58] [Facets] update filter counts on filter selection (#2988) --- assets/facets.js | 39 ++++++++++++++++++++++++++++++++++----- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/assets/facets.js b/assets/facets.js index 21407ab5d59..1296864348b 100644 --- a/assets/facets.js +++ b/assets/facets.js @@ -147,14 +147,43 @@ class FacetFiltersForm extends HTMLElement { } static renderCounts(source, target) { - const targetElement = target.querySelector('.facets__selected'); - const sourceElement = source.querySelector('.facets__selected'); + const filterIsDrawer = Boolean(document.querySelector('.facets-container-drawer')); + const targetElement = filterIsDrawer + ? target.querySelector('.mobile-facets__list') + : target.querySelector('.facets__selected'); + const sourceElement = filterIsDrawer + ? source.querySelector('.mobile-facets__list') + : source.querySelector('.facets__selected'); - const targetElementAccessibility = target.querySelector('.facets__summary'); - const sourceElementAccessibility = source.querySelector('.facets__summary'); + const targetElementAccessibility = filterIsDrawer && target.querySelector('.facets__summary'); + const sourceElementAccessibility = filterIsDrawer && source.querySelector('.facets__summary'); if (sourceElement && targetElement) { - target.querySelector('.facets__selected').outerHTML = source.querySelector('.facets__selected').outerHTML; + const currentActiveID = document.activeElement.id; + const isShowingMore = Boolean(target.querySelector('show-more-button .label-show-more.hidden')); + + if (sourceElement && targetElement) { + targetElement.outerHTML = sourceElement.outerHTML; + } + + if (!filterIsDrawer) { + const targetWrapElement = target.querySelector('.facets-wrap'); + const sourceWrapElement = source.querySelector('.facets-wrap'); + if (sourceWrapElement && targetWrapElement) { + if (isShowingMore) { + sourceWrapElement + .querySelectorAll('.facets__item.hidden') + .forEach((x) => x.classList.replace('hidden', 'show-more-item')); + } + + targetWrapElement.outerHTML = sourceWrapElement.outerHTML; + } + } + + const newElementToActivate = document.getElementById(`${currentActiveID}`); + if (newElementToActivate) { + newElementToActivate.focus(); + } } if (targetElementAccessibility && sourceElementAccessibility) { From 9f26497dc66a17f05435a0e1bf67008a4ca776b2 Mon Sep 17 00:00:00 2001 From: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com> Date: Thu, 21 Sep 2023 08:45:10 -0700 Subject: [PATCH 06/58] Correct CSS (#3003) --- assets/quick-order-list.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/quick-order-list.css b/assets/quick-order-list.css index 36aad4d3d01..0f4408794aa 100644 --- a/assets/quick-order-list.css +++ b/assets/quick-order-list.css @@ -680,7 +680,7 @@ quick-order-list-remove-button { margin-bottom: 2rem; } - .quick-order-list-total__confirmation quick-order-list-remove-all-button.button { + .quick-order-list-total__confirmation quick-order-list-remove-all-button button { margin-top: 1rem; } From 770621b615d12035ae5d7f5116fba8b89097e36d Mon Sep 17 00:00:00 2001 From: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com> Date: Thu, 21 Sep 2023 09:18:26 -0700 Subject: [PATCH 07/58] Check if there is compare_at_price (#3000) --- snippets/price.liquid | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snippets/price.liquid b/snippets/price.liquid index 30f3ad3aa73..5d6ca6a1c3b 100644 --- a/snippets/price.liquid +++ b/snippets/price.liquid @@ -56,7 +56,7 @@ {%- endcomment -%}
{%- if product.quantity_price_breaks_configured? -%} - {%- if show_compare_at_price -%} + {%- if show_compare_at_price and compare_at_price -%} {%- unless product.price_varies == false and product.compare_at_price_varies %} {{- 'products.product.price.regular_price' | t -}} From 0458195da488b3ae0a819fb3b2c7464be380b55a Mon Sep 17 00:00:00 2001 From: "translation-platform[bot]" <34770790+translation-platform[bot]@users.noreply.github.com> Date: Tue, 26 Sep 2023 14:31:47 -0400 Subject: [PATCH 08/58] Update 1 translation file (#3012) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> --- locales/zh-TW.schema.json | 82 +++++++++++++++++++-------------------- 1 file changed, 41 insertions(+), 41 deletions(-) diff --git a/locales/zh-TW.schema.json b/locales/zh-TW.schema.json index 028ec149e28..4ccb2e5d14b 100644 --- a/locales/zh-TW.schema.json +++ b/locales/zh-TW.schema.json @@ -319,7 +319,7 @@ "label": "標誌" }, "logo_width": { - "label": "桌面版標誌寬度", + "label": "電腦版標誌寬度", "info": "標誌會自動調整為手機最佳寬度。" }, "favicon": { @@ -486,7 +486,7 @@ "content": "公告" }, "show_social": { - "label": "在桌面顯示圖示" + "label": "在電腦版顯示圖示" }, "header__3": { "content": "國家/地區選擇器", @@ -514,7 +514,7 @@ "label": "標題" }, "desktop_layout": { - "label": "桌面版版面配置", + "label": "電腦版版面配置", "options__1": { "label": "左側大型區塊" }, @@ -621,7 +621,7 @@ "label": "若清單中包含的商品系列比顯示出的更多,請啟用「檢視全部」按鈕" }, "columns_desktop": { - "label": "桌面版的欄數" + "label": "電腦版的欄數" }, "header_mobile": { "content": "行動版版面配置" @@ -694,7 +694,7 @@ "label": "顯示作者" }, "columns_desktop": { - "label": "桌面版的欄數" + "label": "電腦版的欄數" } }, "presets": { @@ -746,7 +746,7 @@ "info": "最適合彈出式視窗或購物車導覽匣類型。" }, "columns_desktop": { - "label": "桌面版的欄數" + "label": "電腦版的欄數" }, "description": { "label": "說明" @@ -779,7 +779,7 @@ "label": "「檢視更多」樣式" }, "enable_desktop_slider": { - "label": "在桌面版啟用輪播廣告" + "label": "在電腦版啟用輪播廣告" }, "full_width": { "label": "讓產品以全寬度呈現" @@ -911,7 +911,7 @@ "name": "標頭", "settings": { "logo_position": { - "label": "桌面版標誌位置", + "label": "電腦版標誌位置", "options__1": { "label": "中央左方" }, @@ -935,7 +935,7 @@ "label": "下方邊界" }, "menu_type_desktop": { - "label": "桌面版選單類型", + "label": "電腦版選單類型", "info": "行動版的選單類型會自動調整大小。", "options__1": { "label": "下拉式選單" @@ -1016,7 +1016,7 @@ "label": "在行動裝置上堆疊圖片" }, "show_text_box": { - "label": "在桌面顯示容器" + "label": "在電腦版顯示容器" }, "image_overlay_opacity": { "label": "圖片疊加層透明度" @@ -1068,7 +1068,7 @@ "options__9": { "label": "下方靠右" }, - "label": "桌面版內容位置" + "label": "電腦版內容位置" }, "desktop_content_alignment": { "options__1": { @@ -1080,7 +1080,7 @@ "options__3": { "label": "靠右" }, - "label": "桌面版內容對齊方式" + "label": "電腦版內容對齊方式" }, "mobile_content_alignment": { "options__1": { @@ -1185,7 +1185,7 @@ "options__2": { "label": "圖片秒數" }, - "label": "桌面版圖片位置", + "label": "電腦版圖片位置", "info": "圖片會先預設為行動版版面配置。" }, "desktop_image_width": { @@ -1198,7 +1198,7 @@ "options__3": { "label": "大" }, - "label": "桌面版圖片寬度", + "label": "電腦版圖片寬度", "info": "行動版的圖片會自動調整大小。" }, "desktop_content_alignment": { @@ -1208,7 +1208,7 @@ "options__3": { "label": "靠右" }, - "label": "桌面版內容對齊方式", + "label": "電腦版內容對齊方式", "options__2": { "label": "置中" } @@ -1223,7 +1223,7 @@ "options__3": { "label": "靠下" }, - "label": "桌面版內容位置" + "label": "電腦版內容位置" }, "content_layout": { "options__1": { @@ -1395,7 +1395,7 @@ "label": "顯示作者" }, "layout": { - "label": "桌面版版面配置", + "label": "電腦版版面配置", "options__1": { "label": "網格" }, @@ -1501,7 +1501,7 @@ "info": "最適合彈出式視窗或購物車導覽匣類型。" }, "columns_desktop": { - "label": "桌面版的欄數" + "label": "電腦版的欄數" }, "header_mobile": { "content": "行動版版面配置" @@ -1516,7 +1516,7 @@ } }, "filter_type": { - "label": "桌面版濾鏡版面配置", + "label": "電腦版濾鏡版面配置", "options__1": { "label": "水平" }, @@ -1571,7 +1571,7 @@ "info": "編輯您的商品系列以新增圖片。[瞭解詳情](https://help.shopify.com/manual/products/collections)" }, "columns_desktop": { - "label": "桌面版的欄數" + "label": "電腦版的欄數" }, "header_mobile": { "content": "行動版版面配置" @@ -1995,13 +1995,13 @@ "label": "啟用影片循環播放功能" }, "enable_sticky_info": { - "label": "在桌面版啟用黏性內容" + "label": "在電腦版啟用黏性內容" }, "hide_variants": { "label": "在選取一個子類後,隱藏其他子類的多媒體檔案" }, "gallery_layout": { - "label": "桌面版版面配置", + "label": "電腦版版面配置", "options__1": { "label": "已堆疊" }, @@ -2016,7 +2016,7 @@ } }, "media_size": { - "label": "桌面版多媒體檔案寬度", + "label": "電腦版多媒體檔案寬度", "options__1": { "label": "小" }, @@ -2041,7 +2041,7 @@ } }, "media_position": { - "label": "桌面版多媒體檔案位置", + "label": "電腦版多媒體檔案位置", "info": "行動版會自動調整為最佳位置。", "options__1": { "label": "靠左" @@ -2116,7 +2116,7 @@ "info": "新增產品評等應用程式,即可顯示評等。[瞭解詳情](https://help.shopify.com/manual/online-store/themes/theme-structure/page-types#search-results-section-settings)" }, "columns_desktop": { - "label": "桌面版的欄數" + "label": "電腦版的欄數" }, "header_mobile": { "content": "行動版版面配置" @@ -2193,7 +2193,7 @@ "label": "啟用行動裝置的滑動功能" }, "columns_desktop": { - "label": "桌面版的欄數" + "label": "電腦版的欄數" }, "header_mobile": { "content": "行動版版面配置" @@ -2296,7 +2296,7 @@ "options__3": { "label": "靠右" }, - "label": "桌面版內容位置", + "label": "電腦版內容位置", "info": "行動版會自動調整為最佳位置。" }, "content_alignment": { @@ -2559,10 +2559,10 @@ "label": "啟用影片循環播放功能" }, "hide_variants": { - "label": "隱藏桌面版未選擇的子類多媒體檔案" + "label": "隱藏電腦版未選擇的子類多媒體檔案" }, "media_position": { - "label": "桌面版多媒體檔案位置", + "label": "電腦版多媒體檔案位置", "info": "行動版會自動調整為最佳位置。", "options__1": { "label": "靠左" @@ -2589,7 +2589,7 @@ "label": "顯示背景圖片" }, "show_text_box": { - "label": "在桌面顯示容器" + "label": "在電腦版顯示容器" }, "image_overlay_opacity": { "label": "圖片疊加層透明度" @@ -2642,7 +2642,7 @@ "options__3": { "label": "上方靠右" }, - "label": "桌面版內容位置" + "label": "電腦版內容位置" }, "desktop_content_alignment": { "options__1": { @@ -2654,7 +2654,7 @@ "options__3": { "label": "靠右" }, - "label": "桌面版內容對齊方式" + "label": "電腦版內容對齊方式" }, "header": { "content": "行動版版面配置" @@ -2790,7 +2790,7 @@ "label": "使用外框按鈕樣式" }, "box_align": { - "label": "桌面版內容位置", + "label": "電腦版內容位置", "options__1": { "label": "上方靠左" }, @@ -2821,10 +2821,10 @@ "info": "行動版會自動調整為最佳位置。" }, "show_text_box": { - "label": "在桌面顯示容器" + "label": "在電腦版顯示容器" }, "text_alignment": { - "label": "桌面版內容對齊方式", + "label": "電腦版內容對齊方式", "option_1": { "label": "靠左" }, @@ -2916,7 +2916,7 @@ } }, "desktop_layout": { - "label": "桌面版版面配置", + "label": "電腦版版面配置", "options__1": { "label": "先顯示圖片" }, @@ -3113,7 +3113,7 @@ "label": "商品數量顯示上限" }, "columns_desktop": { - "label": "桌面版的欄數" + "label": "電腦版的欄數" }, "paragraph__1": { "content": "動態推薦會使用訂單和商品資訊,以隨著時間改變與改進。[瞭解詳情](https://help.shopify.com/themes/development/recommended-products)" @@ -3188,7 +3188,7 @@ "options__3": { "label": "大" }, - "label": "桌面版圖片寬度", + "label": "電腦版圖片寬度", "info": "行動版的圖片會自動調整大小。" }, "heading_size": { @@ -3231,7 +3231,7 @@ "options__3": { "label": "靠右" }, - "label": "桌面版內容對齊方式" + "label": "電腦版內容對齊方式" }, "desktop_content_position": { "options__1": { @@ -3243,7 +3243,7 @@ "options__3": { "label": "靠下" }, - "label": "桌面版內容位置", + "label": "電腦版內容位置", "info": "行動版會自動調整為最佳位置。" }, "image_layout": { @@ -3259,7 +3259,7 @@ "options__4": { "label": "靠右對齊" }, - "label": "桌面版圖片位置", + "label": "電腦版圖片位置", "info": "行動版的圖片會自動調整位置。" }, "container_color_scheme": { From dbdc28cf42e95061acfa9b64b14698921fd19f62 Mon Sep 17 00:00:00 2001 From: Patrick Racicot Date: Mon, 2 Oct 2023 16:09:23 -0400 Subject: [PATCH 09/58] [Facets] fix mobile count update (#3018) --- assets/facets.js | 68 +++++++++++++++++++++++------------------------- 1 file changed, 33 insertions(+), 35 deletions(-) diff --git a/assets/facets.js b/assets/facets.js index 1296864348b..6a242c1cc7d 100644 --- a/assets/facets.js +++ b/assets/facets.js @@ -120,7 +120,18 @@ class FacetFiltersForm extends HTMLElement { FacetFiltersForm.renderActiveFacets(parsedHTML); FacetFiltersForm.renderAdditionalElements(parsedHTML); - if (countsToRender) FacetFiltersForm.renderCounts(countsToRender, event.target.closest('.js-filter')); + if (countsToRender) { + const closestJSFilterID = event.target.closest('.js-filter').id; + const currentActiveID = document.activeElement.id; + + if (closestJSFilterID) { + FacetFiltersForm.renderCounts(countsToRender, event.target.closest('.js-filter')); + FacetFiltersForm.renderMobileCounts(countsToRender, document.getElementById(closestJSFilterID)); + + const newElementToActivate = document.getElementById(currentActiveID); + if (newElementToActivate) newElementToActivate.focus(); + } + } } static renderActiveFacets(html) { @@ -147,47 +158,34 @@ class FacetFiltersForm extends HTMLElement { } static renderCounts(source, target) { - const filterIsDrawer = Boolean(document.querySelector('.facets-container-drawer')); - const targetElement = filterIsDrawer - ? target.querySelector('.mobile-facets__list') - : target.querySelector('.facets__selected'); - const sourceElement = filterIsDrawer - ? source.querySelector('.mobile-facets__list') - : source.querySelector('.facets__selected'); - - const targetElementAccessibility = filterIsDrawer && target.querySelector('.facets__summary'); - const sourceElementAccessibility = filterIsDrawer && source.querySelector('.facets__summary'); - - if (sourceElement && targetElement) { - const currentActiveID = document.activeElement.id; - const isShowingMore = Boolean(target.querySelector('show-more-button .label-show-more.hidden')); + const targetSummary = target.querySelector('.facets__summary'); + const sourceSummary = source.querySelector('.facets__summary'); - if (sourceElement && targetElement) { - targetElement.outerHTML = sourceElement.outerHTML; - } + if (sourceSummary && targetSummary) { + targetSummary.outerHTML = sourceSummary.outerHTML; + } - if (!filterIsDrawer) { - const targetWrapElement = target.querySelector('.facets-wrap'); - const sourceWrapElement = source.querySelector('.facets-wrap'); - if (sourceWrapElement && targetWrapElement) { - if (isShowingMore) { - sourceWrapElement - .querySelectorAll('.facets__item.hidden') - .forEach((x) => x.classList.replace('hidden', 'show-more-item')); - } + const targetWrapElement = target.querySelector('.facets-wrap'); + const sourceWrapElement = source.querySelector('.facets-wrap'); - targetWrapElement.outerHTML = sourceWrapElement.outerHTML; - } + if (sourceWrapElement && targetWrapElement) { + const isShowingMore = Boolean(target.querySelector('show-more-button .label-show-more.hidden')); + if (isShowingMore) { + sourceWrapElement + .querySelectorAll('.facets__item.hidden') + .forEach((hiddenItem) => hiddenItem.classList.replace('hidden', 'show-more-item')); } - const newElementToActivate = document.getElementById(`${currentActiveID}`); - if (newElementToActivate) { - newElementToActivate.focus(); - } + targetWrapElement.outerHTML = sourceWrapElement.outerHTML; } + } + + static renderMobileCounts(source, target) { + const targetFacetsList = target.querySelector('.mobile-facets__list'); + const sourceFacetsList = source.querySelector('.mobile-facets__list'); - if (targetElementAccessibility && sourceElementAccessibility) { - target.querySelector('.facets__summary').outerHTML = source.querySelector('.facets__summary').outerHTML; + if (sourceFacetsList && targetFacetsList) { + targetFacetsList.outerHTML = sourceFacetsList.outerHTML; } } From 27b5f3fbcbacd0dd51c615b16f7158eb596a11a1 Mon Sep 17 00:00:00 2001 From: "translation-platform[bot]" <34770790+translation-platform[bot]@users.noreply.github.com> Date: Wed, 4 Oct 2023 09:47:11 -0400 Subject: [PATCH 10/58] Update 1 translation file (#3043) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> --- locales/fr.schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/locales/fr.schema.json b/locales/fr.schema.json index e4fc2042d5a..7902e9a0ad5 100644 --- a/locales/fr.schema.json +++ b/locales/fr.schema.json @@ -519,7 +519,7 @@ "label": "Grand bloc gauche" }, "options__2": { - "label": "Grand bloc droit" + "label": "Grand bloc droite" } }, "mobile_layout": { From a32602b918bb78b9c48b4939fe37c1dfd0e61445 Mon Sep 17 00:00:00 2001 From: "translation-platform[bot]" <34770790+translation-platform[bot]@users.noreply.github.com> Date: Wed, 4 Oct 2023 15:21:54 -0400 Subject: [PATCH 11/58] Update 1 translation file (#3044) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> --- locales/cs.schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/locales/cs.schema.json b/locales/cs.schema.json index f6b14ce0c7b..b1a25d0822b 100644 --- a/locales/cs.schema.json +++ b/locales/cs.schema.json @@ -1637,7 +1637,7 @@ "name": "Selektor množství" }, "variant_picker": { - "name": "Výběr varianty", + "name": "Selektor variant", "settings": { "picker_type": { "label": "Typ", @@ -2479,7 +2479,7 @@ "name": "Selektor množství" }, "variant_picker": { - "name": "Výběr varianty", + "name": "Selektor variant", "settings": { "picker_type": { "label": "Typ", From 5c8c1513b9f280ce74884e2b12e05c3f1a8a8943 Mon Sep 17 00:00:00 2001 From: Ludo Date: Thu, 5 Oct 2023 08:35:59 -0400 Subject: [PATCH 12/58] [Image with text] Add color scheme picker for section wrapper (#3016) * [Image with text] Add color scheme picker for section wrapper * address review comment about overlap and transparency --- assets/component-image-with-text.css | 4 +- sections/image-with-text.liquid | 150 +++++++++++++++------------ sections/multirow.liquid | 2 +- 3 files changed, 84 insertions(+), 72 deletions(-) diff --git a/assets/component-image-with-text.css b/assets/component-image-with-text.css index fcf450334fd..e8a5a3c96b5 100644 --- a/assets/component-image-with-text.css +++ b/assets/component-image-with-text.css @@ -313,8 +313,8 @@ } /* Needed for gradient continuity with or without animation so that transparent PNG images come up as we would expect */ -.image-with-text:not(.image-with-text--overlap) .color-background-1, -.image-with-text.image-with-text--overlap .image-with-text__media.color-background-1 { +.image-with-text.image-with-text--overlap .backround-transparent, +.image-with-text:not(.image-with-text--overlap) .background-transparent { background: transparent; } diff --git a/sections/image-with-text.liquid b/sections/image-with-text.liquid index 359324b2046..fcb92495d97 100644 --- a/sections/image-with-text.liquid +++ b/sections/image-with-text.liquid @@ -15,87 +15,93 @@ {%- endstyle -%} {%- liquid - assign scheme1 = settings.color_schemes | first assign fetch_priority = 'auto' if section.index == 1 assign fetch_priority = 'high' endif + if section.settings.color_scheme == section.settings.section_color_scheme and section.settings.content_layout == 'no-overlap' + assign remove_color_classes = true + endif -%} -
-
-
-
- {%- if section.settings.image != blank -%} - {%- if section.settings.image_behavior == 'ambient' or section.settings.image_behavior == 'zoom-in' -%} - {%- assign widths = '198, 432, 642, 900, 1284, 1800' -%} - {%- capture sizes -%} +
+
+
+
+
+
+ {%- if section.settings.image != blank -%} + {%- if section.settings.image_behavior == 'ambient' or section.settings.image_behavior == 'zoom-in' -%} + {%- assign widths = '198, 432, 642, 900, 1284, 1800' -%} + {%- capture sizes -%} (min-width: {{ settings.page_width }}px) {{ settings.page_width | minus: 100 | divided_by: 1.6667 }}px, (min-width: 750px) calc((100vw - 130px) / 1.667), calc((100vw - 50px) / 1.667) {%- endcapture -%} - {%- else -%} - {%- assign widths = '165, 360, 535, 750, 1070, 1500' -%} - {%- capture sizes -%} + {%- else -%} + {%- assign widths = '165, 360, 535, 750, 1070, 1500' -%} + {%- capture sizes -%} (min-width: {{ settings.page_width }}px) {{ settings.page_width | minus: 100 | divided_by: 2 }}px, (min-width: 750px) calc((100vw - 130px) / 2), calc((100vw - 50px) / 2) {%- endcapture -%} - {%- endif -%} - {{ - section.settings.image - | image_url: width: 1500 - | image_tag: sizes: sizes, widths: widths, fetchpriority: fetch_priority - }} - {%- else -%} - {{ 'detailed-apparel-1' | placeholder_svg_tag: 'placeholder-svg' }} - {%- endif -%} -
-
-
-
- {%- for block in section.blocks -%} - {% case block.type %} - {%- when 'heading' -%} -

- {{ block.settings.heading }} -

- {%- when 'caption' -%} -

- {{ block.settings.caption | escape }} -

- {%- when 'text' -%} -
- {{ block.settings.text }} -
- {%- when 'button' -%} - {%- if block.settings.button_label != blank -%} - - {{ block.settings.button_label | escape }} - {%- endif -%} - {%- endcase -%} - {%- endfor -%} + {{ + section.settings.image + | image_url: width: 1500 + | image_tag: sizes: sizes, widths: widths, fetchpriority: fetch_priority + }} + {%- else -%} + {{ 'detailed-apparel-1' | placeholder_svg_tag: 'placeholder-svg' }} + {%- endif -%} +
+
+
+
+ {%- for block in section.blocks -%} + {% case block.type %} + {%- when 'heading' -%} +

+ {{ block.settings.heading }} +

+ {%- when 'caption' -%} +

+ {{ block.settings.caption | escape }} +

+ {%- when 'text' -%} +
+ {{ block.settings.text }} +
+ {%- when 'button' -%} + {%- if block.settings.button_label != blank -%} + + {{ block.settings.button_label | escape }} + + {%- endif -%} + {%- endcase -%} + {%- endfor -%} +
+
@@ -234,10 +240,16 @@ }, { "type": "color_scheme", - "id": "color_scheme", + "id": "section_color_scheme", "label": "t:sections.all.colors.label", "default": "background-1" }, + { + "type": "color_scheme", + "id": "color_scheme", + "label": "t:sections.multirow.settings.container_color_scheme.label", + "default": "background-1" + }, { "type": "header", "content": "t:sections.all.animation.content" diff --git a/sections/multirow.liquid b/sections/multirow.liquid index e600f974e85..d49ed6f8a70 100644 --- a/sections/multirow.liquid +++ b/sections/multirow.liquid @@ -73,7 +73,7 @@
-
+
{%- if block.settings.caption -%}

{{ block.settings.caption | escape }} From 7ee3da2b1964b3cd46d9780af2f8130df88a25ea Mon Sep 17 00:00:00 2001 From: Andrew Etchen Date: Thu, 5 Oct 2023 10:33:03 -0400 Subject: [PATCH 13/58] Refactor `quick-order-list.css` (#3006) --- assets/quick-order-list.css | 132 +++++------------------------------- 1 file changed, 18 insertions(+), 114 deletions(-) diff --git a/assets/quick-order-list.css b/assets/quick-order-list.css index 0f4408794aa..4bea213ae19 100644 --- a/assets/quick-order-list.css +++ b/assets/quick-order-list.css @@ -11,10 +11,6 @@ quick-order-list .quantity__button { width: calc(3.5rem / var(--font-body-scale)); } -.quick-order-list__contents { - position: relative; -} - .quick-order-list__container { padding-bottom: 4rem; } @@ -28,10 +24,6 @@ quick-order-list .quantity__button { border-top: 0.1rem solid rgba(var(--color-foreground), .08); } -.totals__product-total { - text-align: center; -} - .variant-item__quantity .quantity:before { z-index: 0; } @@ -48,15 +40,6 @@ quick-order-list .quantity__button { background-color: rgb(var(--color-background)); } - .totals__product-total { - text-align: right; - } - - .variant__items { - max-height: 90rem; - overflow-y: auto; - } - .variant-item__quantity-wrapper--no-info, .variant-item__error { padding-left: calc(15px + 3.4rem); @@ -142,10 +125,6 @@ quick-order-list .quantity__button { display: flex; } - .quick-order-list__table .variant-item__inner.variant-item__inner--no-sku { - vertical-align: middle; - } - .variant-item__discounted-prices { justify-content: flex-end; } @@ -161,7 +140,6 @@ quick-order-list .quantity__button { max-width: 30rem; } - .variant-item__info { position: relative; padding-bottom: 0.5rem; @@ -208,12 +186,6 @@ quick-order-list .quantity__button { font-weight: 400; } -.product-option { - font-size: 1.4rem; - word-break: break-word; - line-height: calc(1 + 0.5 / var(--font-body-scale)); -} - .variant-item__sold-out { opacity: 0.7; font-size: 1.6rem; @@ -222,7 +194,7 @@ quick-order-list .quantity__button { quick-order-list-remove-button { display: flex; - margin-left: 1rem; + margin: 0 0 0 1.2rem; align-self: center; } @@ -242,14 +214,7 @@ quick-order-list-remove-button { margin-top: 1rem; } - .quick-order-list-buttons { - display: flex; - justify-content: space-between; - flex-direction: column; - } - .quick-order-list-total__column { - display: flex; flex-wrap: wrap; } @@ -266,18 +231,10 @@ quick-order-list-remove-button .button { margin: 0 0.1rem 0.1rem 0; } - quick-order-list-remove-button .button:not([disabled]):hover { color: rgb(var(--color-foreground)); } -@media screen and (min-width: 990px) { - quick-order-list-remove-button .button { - min-width: 1.5rem; - min-height: 1.5rem; - } -} - quick-order-list-remove-button .icon-remove { height: 1.5rem; width: 1.5rem; @@ -292,6 +249,11 @@ quick-order-list-remove-button .icon-remove { padding: 0; } +.variant-remove-total { + position: relative; + align-self: center; +} + .variant-remove-total .button--tertiary { width: max-content; } @@ -302,16 +264,16 @@ quick-order-list-remove-button .icon-remove { margin-right: 0.8rem; } -.quick-order-list__message svg { - margin-right: 1rem; - width: 1.3rem; -} - .quick-order-list__message { margin-top: 1rem; display: block; } +.quick-order-list__message svg { + margin-right: 1rem; + width: 1.3rem; +} + .quick-order-list-error { margin-top: 1rem; display: flex; @@ -350,11 +312,6 @@ quick-order-list-remove-button:hover .icon-remove { text-underline-offset: 0.3rem; } -.variant-remove-total { - position: relative; - align-self: center; -} - .variant-item .loading-overlay:not(.hidden)~*, .variant-remove-total .loading-overlay:not(.hidden)~* { visibility: hidden; @@ -385,15 +342,6 @@ quick-order-list-remove-button:hover .icon-remove { display: none; } -.product-option+.product-option { - margin-top: 0.4rem; -} - -.product-option * { - display: inline; - margin: 0; -} - .quick-order-list__table thead th { text-transform: uppercase; } @@ -472,17 +420,12 @@ quick-order-list-remove-button:hover .icon-remove { text-align: center; } - .quick-order-list-total__column { + .quick-order-list-total__column, + .quick-order-list-buttons { display: flex; flex-direction: column; align-items: center; - } - - .quick-order-list-buttons { width: 100%; - align-items: center; - display: flex; - flex-direction: column; } .quick-order-list__button { @@ -497,10 +440,6 @@ quick-order-list-remove-button:hover .icon-remove { margin-top: -2rem; } -.quick-order-list-total__confirmation .button--tertirary { - margin-left: 2rem; -} - @media screen and (min-width: 990px) { .quick-order-list__table { border-spacing: 0; @@ -514,10 +453,6 @@ quick-order-list-remove-button:hover .icon-remove { border-bottom: 0.1rem solid rgba(var(--color-foreground), 0.08); } - .quick-order-list__table thead th:first-child { - width: 20%; - } - .quick-order-list__table th+th { padding-left: 5.4rem; } @@ -529,7 +464,6 @@ quick-order-list-remove-button:hover .icon-remove { .quick-order-list__table td { padding-top: 1.6rem; - vertical-align: middle; } .quick-order-list__table .desktop-row-error td { @@ -537,8 +471,7 @@ quick-order-list-remove-button:hover .icon-remove { } .quick-order-list__table .variant-item--unit-price td { - vertical-align: top; - + vertical-align: middle; } .variant-item { @@ -559,10 +492,6 @@ quick-order-list-remove-button:hover .icon-remove { margin-right: 3rem; } - .quick-order-list-total__column { - width: 20%; - } - .quick-order-list__total-items { width: calc(((11rem / var(--font-body-scale) + var(--inputs-border-width) * 2))); margin-left: calc(15px + 3.4rem); @@ -570,26 +499,14 @@ quick-order-list-remove-button:hover .icon-remove { } } -quick-order-list-remove-button { - margin: 0 0 0 1.2rem; -} - @media screen and (min-width: 990px) { - .variant-item .variant-item__quantity { - padding-left: 0; - } - - .quick-order-list__table thead th:first-child { - width: 37%; - } - + .quick-order-list__table thead th:first-child, .quick-order-list-total__column { width: 37%; } .quick-order-list-buttons { display: flex; - align-self: flex-start; } quick-order-list-remove-all-button { @@ -629,21 +546,13 @@ quick-order-list-remove-button { min-height: 10rem; } -.quick-order-list-total { - padding-top: 2rem; - border-top: 0.1rem solid rgba(var(--color-foreground), .08); -} - .quick-order-list-total__price { display: flex; flex-wrap: wrap; justify-content: flex-end; - width: min-content; -} - -.quick-order-list-total__price { flex-grow: 1; text-align: right; + width: min-content; } .quick-order-list-total__price .button { @@ -660,7 +569,6 @@ quick-order-list-remove-button { .totals__product-total { display: flex; justify-content: center; - text-align: center; width: 100%; align-items: center; padding-bottom: 2rem; @@ -689,22 +597,18 @@ quick-order-list-remove-button { margin-top: 2rem; } - .quick-order-list-total__column { - width: 100%; - } - .quick-order-list__button-confirm { width: 100%; max-width: 36rem; } quick-order-list .tax-note { - text-align: center + text-align: center; } } quick-order-list .tax-note { - margin-bottom: 2rem; + margin: 0 0 2rem; display: block; width: 100%; } From a64da0f160c065b6bc17c307563d233b172c8645 Mon Sep 17 00:00:00 2001 From: Ludo Date: Thu, 5 Oct 2023 13:49:58 -0400 Subject: [PATCH 14/58] Fix Add to Cart error on page load/slower connections (#3008) --- assets/product-form.js | 6 +++++- snippets/buy-buttons.liquid | 4 +++- snippets/card-product.liquid | 4 +++- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/assets/product-form.js b/assets/product-form.js index 4deccf99b41..cb7374348fd 100644 --- a/assets/product-form.js +++ b/assets/product-form.js @@ -66,7 +66,11 @@ if (!customElements.get('product-form')) { } if (!this.error) - publish(PUB_SUB_EVENTS.cartUpdate, { source: 'product-form', productVariantId: formData.get('id'), cartData: response }); + publish(PUB_SUB_EVENTS.cartUpdate, { + source: 'product-form', + productVariantId: formData.get('id'), + cartData: response, + }); this.error = false; const quickAddModal = this.closest('quick-add-modal'); if (quickAddModal) { diff --git a/snippets/buy-buttons.liquid b/snippets/buy-buttons.liquid index c302aacbc33..1d7cc6c146f 100644 --- a/snippets/buy-buttons.liquid +++ b/snippets/buy-buttons.liquid @@ -55,7 +55,9 @@ type="hidden" name="id" value="{{ product.selected_or_first_available_variant.id }}" - disabled + {% if product.selected_or_first_available_variant.available == false or quantity_rule_soldout %} + disabled + {% endif %} class="product-variant-id" > diff --git a/snippets/card-product.liquid b/snippets/card-product.liquid index b8be5fb6b86..5935fe18a27 100644 --- a/snippets/card-product.liquid +++ b/snippets/card-product.liquid @@ -277,7 +277,9 @@ name="id" value="{{ card_product.selected_or_first_available_variant.id }}" class="product-variant-id" - disabled + {% if card_product.selected_or_first_available_variant.available == false %} + disabled + {% endif %} > - -

- - + + +
+ + {%- if settings.predictive_search_enabled -%} {%- endif -%} -
{%- if search.performed -%} {%- unless section.settings.enable_filtering or section.settings.enable_sorting -%} {%- if search.results_count > 0 -%} -

{{ 'templates.search.results_with_count_and_term' | t: terms: search.terms, count: search.results_count }}

+

+ {{ 'templates.search.results_with_count_and_term' | t: terms: search.terms, count: search.results_count }} +

{%- endif -%} {%- endunless -%} {%- if search.results_count == 0 and search.filters == empty -%} @@ -145,7 +146,10 @@ {%- endif -%}
{%- if search.performed -%} - {%- if section.settings.enable_sorting and section.settings.filter_type == 'vertical' and search.filters != empty -%} + {%- if section.settings.enable_sorting + and section.settings.filter_type == 'vertical' + and search.filters != empty + -%}
@@ -155,16 +159,30 @@
{%- assign sort_by = search.sort_by | default: search.default_sort_by -%} - {%- for option in search.sort_options -%} - + {%- endfor -%} {% render 'icon-caret' %}
@@ -176,52 +194,83 @@ {%- elsif search.products_count == search.all_products_count -%} {{ 'products.facets.product_count_simple' | t: count: search.products_count }} {%- else -%} - {{ 'products.facets.product_count' | t: product_count: search.products_count, count: search.all_products_count }} + {{ + 'products.facets.product_count' + | t: product_count: search.products_count, count: search.all_products_count + }} {%- endif -%} -
- -
+ {%- render 'loading-spinner' -%}
{%- endif -%} - +
{%- if search.filters != empty -%} {%- if section.settings.enable_filtering or section.settings.enable_sorting -%} -