Fixed superfluous bug #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gowtham H N <[email protected]>
GowthamHN
force-pushed
the
superfluous-header-bug-fix
branch
from
600557f to
352c372
Compare
cicoyle
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
I can confirm I was seeing this locally as well and had to make this same change to resolve this err:
== APP == 2024/10/22 13:54:53 http: superfluous response.WriteHeader call from [github.com/dapr/go-sdk/service/http.(*Server).registerBaseHandler.func6](http://github.com/dapr/go-sdk/service/http.(*Server).registerBaseHandler.func6) (topic.go:214)
mikeee
approved these changes
Oct 28, 2024
|
Thanks for your contribution @GowthamHN |
|
@holopin-bot @GowthamHN Thank you! |
|
Congratulations @GowthamHN, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm489a4mn03480cmqr6zv7je9 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made the writeHeader calls non superfluous.
Issue reference
#618
Please reference the issue this PR will close: #618