add validate module.yaml file #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juev
force-pushed
the
feature/validate-module-yaml
branch
from
d7557a8 to
ca5b0a7
Compare
ldmonster
reviewed
Jan 16, 2025
|
|
||
| _, err := os.Stat(filepath.Join(modulePath, ModuleConfigFilename)) | ||
| if err != nil { | ||
| return lintRuleErrorsList |
There was a problem hiding this comment.
are we sure, that we need to ignore all stat errors?
There was a problem hiding this comment.
What proposals will there be?
There was a problem hiding this comment.
Suggested change
| return lintRuleErrorsList | |
| _, err := os.Stat(filepath.Join(modulePath, ModuleConfigFilename)) | |
| if errors.Is(err, os.ErrNotExist) { | |
| return lintRuleErrorsList | |
| } | |
| if err != nil { | |
| lintRuleErrorsList.Add(errors.NewLintRuleError( | |
| ID, | |
| moduleName, | |
| moduleName, | |
| nil, | |
| "Cannot stat file %q: %s", | |
| ModuleConfigFilename, err.Error(), | |
| )) | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #52