Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyJSON Refactor and Improvements #35

Open
4 tasks
jkeon opened this issue Jun 10, 2020 · 0 comments
Open
4 tasks

TinyJSON Refactor and Improvements #35

jkeon opened this issue Jun 10, 2020 · 0 comments
Labels
effort-intense Sleep on it - 16 to 40 hours priority-low Get to it when you get to it. No rush. status-backlog Tasks captured but not yet planned. type-chore Clean-up and optimization

Comments

@jkeon
Copy link
Member

jkeon commented Jun 10, 2020

Based off of future work: #34

  • Further refactoring to make the classes cleaner and functions less long.
  • Update style so it's consistent with the rest of the framework.
  • Encoding/Decoding are two separate systems. If you want to add support for Color for example you need to support Decoding in the UnityProxyString AND UnityTinyJSONParser.DTCheckConvert where as to support Encoding you add it in the UnityEncoder. Ideally Encoding/Decoding should be mirrors of each other and not have logic in different locations.
  • There is an issue where if the CSharp and Unity assembly are not in their own assemblies and just all thrown into the main Unity assembly, that the Unity setting of the UnityTinyJSONParser won't happen until after another static constructor has run in the Editor that uses JSON to decode something. If that something uses something that is Unity specific you'll get an error in the console. The override system could be reworked such that JSON searches through all Assemblies and finds the most derived class of TinyJSONParser and instantiates that instead. However for now, since They will be likely be in different assemblies and the app assembly depends on both of them, it's reasonable to conclude that things will be ready in time.
@jkeon jkeon added effort-intense Sleep on it - 16 to 40 hours priority-low Get to it when you get to it. No rush. status-backlog Tasks captured but not yet planned. type-chore Clean-up and optimization labels Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort-intense Sleep on it - 16 to 40 hours priority-low Get to it when you get to it. No rush. status-backlog Tasks captured but not yet planned. type-chore Clean-up and optimization
Projects
None yet
Development

No branches or pull requests

1 participant