-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: No context menu item for paste in an input table #2341
base: main
Are you sure you want to change the base?
fix: No context menu item for paste in an input table #2341
Conversation
This works now but need to revisit how and why
…paste-in-an-input-table
…paste-in-an-input-table
is there any documentation on this?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2341 +/- ##
==========================================
+ Coverage 46.70% 46.76% +0.06%
==========================================
Files 704 710 +6
Lines 39044 39109 +65
Branches 9757 9774 +17
==========================================
+ Hits 18234 18290 +56
- Misses 20799 20808 +9
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exceptions should still be thrown/caught, rather than mapping to null
. Excellent work, great find confirming the old behaviour in Firefox as well!
clipboard-read
permission (e.g. Chrome), clicking paste results in the same behaviour as pressing the keyboard shortcut, provided the user has accepted the request for permissionclipboard-read
permission (e.g. Firefox and Safari), a modal is shown to explain the reason and to suggest using the keyboard shortcut insteadAdditional related issues fixed
instead of
which we were expecting before. Was able to reproduce former behaviour on an older build of Firefox (91.0), meaning this discrepancy is likely caused by an update to Firefox (unsure when exactly)