Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The function of checking the format of the training dataset needs to be enhanced in deepks #5747

Open
14 tasks
Chentao168 opened this issue Dec 20, 2024 · 0 comments
Assignees
Labels
DeePKS Issues related to the DeePKS Refactor Refactor ABACUS codes

Comments

@Chentao168
Copy link
Collaborator

Background

The format of the training dataset of DeePKS differs significantly from that of DeePMD-kit, and there is no format checking function. Errors caused by data formatting are difficult to detect.

Describe the solution you'd like

Add format checking function and make the format of the training dataset of DeePKS similar to that of DeePMD-kit.

Task list only for developers

  • Notice possible changes of behavior
  • Explain the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi

Notice Possible Changes of Behavior (Reminder only for developers)

No response

Notice any changes of core modules (Reminder only for developers)

No response

Notice Possible Changes of Core Modules (Reminder only for developers)

No response

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Review and understand the proposed feature and its importance.
  • Research on the existing solutions and relevant research articles/resources.
  • Discuss with the team to evaluate the feasibility of implementing the feature.
  • Create a design document outlining the proposed solution and implementation details.
  • Get feedback from the team on the design document.
  • Develop the feature following the agreed design.
  • Write unit tests and integration tests for the feature.
  • Update the documentation to include the new feature.
  • Perform code review and address any issues.
  • Merge the feature into the main branch.
  • Monitor for any issues or bugs reported by users after the feature is released.
  • Address any issues or bugs reported by users and continuously improve the feature.
@mohanchen mohanchen added Refactor Refactor ABACUS codes DeePKS Issues related to the DeePKS labels Dec 20, 2024
@ErjieWu ErjieWu self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeePKS Issues related to the DeePKS Refactor Refactor ABACUS codes
Projects
None yet
Development

No branches or pull requests

3 participants