Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-p, --sheetdelimiter help and code incorrect #256

Open
BrianInglis opened this issue Mar 15, 2023 · 0 comments
Open

-p, --sheetdelimiter help and code incorrect #256

BrianInglis opened this issue Mar 15, 2023 · 0 comments

Comments

@BrianInglis
Copy link

xlsx2csv --help shows:

  -p SHEETDELIMITER, --sheetdelimiter SHEETDELIMITER
                        sheet delimiter used to separate sheets,
                        pass '' if you do not need delimiter, or 
                        'x07' or '\f' for form feed (default: '--------')

but '\f' is '\x0c' not '\x07' and the argument is passed to python chr(int(sheetdelimiter[1:])) which converts it to '\a' not '\f'.
Either the sheet delimiter would have to be passed as 'x12' which gives '\f', but just looks so wrong, or change the code to specify the base as hex chr(int(sheetdelimiter[1:],16)) if the prefix is 'x', so then 'x0c' can be passed, and the documentation updated to match. Other approaches might also be reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant